You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org> on 2020/05/13 07:32:11 UTC

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI 

Zoltan Garaguly has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15903


Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M www/log_level.tmpl
2 files changed, 26 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6098/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 13:10:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 5:

Hi Tamas,
Thank you for your comments and suggestions.
Please find a new patch set containing implementation based on your proposal.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 12:28:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5869/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2020 00:20:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7: Code-Review+1

Tamas, did you have time to look at it? I'm gonna give my +2 once it looks good to you.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 13:31:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 8:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6237/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:24:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#12).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 113 insertions(+), 115 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/12
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 13: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 11:47:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4:

Hi Zoltan, thank you for updating the change. This comment became a bit long because it contains 'page design' in text :).

The BE log level part looking good, additionally one slight change could help the users better understand the levels, the meaning of the numbers could be printed as well: https://impala.apache.org/docs/build/html/topics/impala_logging.html#log_levels
ie.:
 1: Default
 2: Debug
 3: All

The FE log4j log levels could be collected as well, then there would be no need for the get log level part there. It can be cumbersome to get the levels one-by-one for every class manually. The 'LogManager.getCurrentLoggers()' can get all the loggers, then 'logger.getLevel()' should return 'null' or the log level if it is set.

With the Java part it would be lot nicer and we could standardize the page layout a bit, ie (concept in text :) ).:
[Text: Frontend log level configuration (log4j)]
[Text: Current log level:]
[Text or Textbox:
Log4j level values class and level]
[Text box: class] [Text: Log level:] [Combobox: level] [Button: Set Java Log Level]
[Button: Reset Frontend Log Level]

[Text: Backend log level configuration (glog)]
[Text: Current log level:] [Glog level value]
[Text: Log level] [Combobox: level] [Button: Set Glog Level]
[Button: Reset Backend Log Level]

Also, I am adding Zoltan Borok-Nagy as a reviewer, hope you have some time to take look at it.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 14:04:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5865/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 11:30:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5869/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 19:02:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#7).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 107 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#9).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 113 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Reviewed-on: http://gerrit.cloudera.org:8080/15903
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 113 insertions(+), 115 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5865/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 17:00:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5958/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:55:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#8).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 113 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/8
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6113/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 12:19:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#10).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request
which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels
on every request:
 -  log4j levels for all java classes previously set are shown on page
    as a list, fetching of individual class log levels not needed
    anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 113 insertions(+), 114 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#5).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels on every request:
 -  log4j levels for all java classes previously set are shown on page as a list,
    fetching of individual class log levels not needed anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 105 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5959/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 11
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:14:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5816/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 11:48:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5972/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 11:47:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15903/5/be/src/util/logging-support.cc
File be/src/util/logging-support.cc:

http://gerrit.cloudera.org:8080/#/c/15903/5/be/src/util/logging-support.cc@142
PS5, Line 142:   for (const string& logLevel: result.loglevels) { 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/15903/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/15903/5/tests/webserver/test_web_pages.py@211
PS5, Line 211:  
flake8: E501 line too long (98 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/15903/5/tests/webserver/test_web_pages.py@236
PS5, Line 236:  
flake8: E501 line too long (98 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 12:12:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6060/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 10:09:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 6: Code-Review+1

(4 comments)

Only found some style issues, other than that LGTM.
I'm ready to upgrade my +1 to +2 once it looks good to Tamas.

http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG@9
PS6, Line 9: h allows:
nit: for log messages we use lines with 72 chars width.


http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc
File be/src/util/logging-support.cc:

http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@143
PS6, Line 143:  
nit:extra space


http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@233
PS6, Line 233:     if (display_log4j_handlers) {
             :       GetJavaLogLevels(doc);
             :     }
nit: fits single line as well


http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift
File common/thrift/Logging.thrift:

http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift@48
PS6, Line 48: loglevels
nit: we use underscores in member names, i.e. it should be log_levels



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 09:36:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#4).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching function.
Fetch glog level on every request which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format next to combo box
Show always default and current glog level on page.
Rename title from "Change Java log level" to "Change frontend logging level".

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
3 files changed, 30 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5828/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 07:51:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5828/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 11:49:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 20:28:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 9:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6238/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:29:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

(2 comments)

Apologies for the delay.

Based on my understanding the 'getLogLevel()' becomes deprecated and will not be called anymore. This method and its thrift object could be removed, other than this LGTM!

http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift
File common/thrift/Logging.thrift:

http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift@38
PS7, Line 38: struct TGetJavaLogLevelParams {
            :   1: required string class_name
            : }
I think this becomes unused as 'getLogLevel()' will not be called anymore.


http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java
File fe/src/main/java/org/apache/impala/util/GlogAppender.java:

http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java@145
PS7, Line 145:   /**
             :    * Get the log4j log level corresponding to a serialized TGetJavaLogLevelParams.
             :    */
             :   public static String getLogLevel(byte[] serializedParams) throws ImpalaException {
             :     TGetJavaLogLevelParams thriftParams = new TGetJavaLogLevelParams();
             :     JniUtil.deserializeThrift(protocolFactory_, thriftParams, serializedParams);
             :     String className = thriftParams.getClass_name();
             :     if (Strings.isNullOrEmpty(className)) return null;
             :     return Logger.getLogger(className).getEffectiveLevel().toString();
             :   }
I think this can be removed, as far as I can see it was only called by the BE earlier, which is now calling the 'getLogLevels()' method.



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 11:47:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 18:16:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift
File common/thrift/Logging.thrift:

http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift@38
PS7, Line 38: // - return value as a list of Java classes with corresponding
            : // logging levels set before using GlogAppender.getLogLevels()
            : s
> I think this becomes unused as 'getLogLevel()' will not be called anymore.
Done


http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java
File fe/src/main/java/org/apache/impala/util/GlogAppender.java:

http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java@145
PS7, Line 145:    * Sets the logging level of a class as per serialized TSetJavaLogLevelParams.
             :    */
             :   public static String setLogLevel(byte[] serializedParams) throws ImpalaException {
             :     TSetJavaLogLevelParams thriftParams = new TSetJavaLogLevelParams();
             :     JniUtil.deserializeThrift(protocolFactory_, thriftParams, serializedParams);
             :     String className = thriftParams.getClass_name();
             :     String logLevel = thriftParams.getLog_level();
             :     if (Strings.isNullOrEmpty(className) || Strings.isNullOrEmpty(logLevel)) return null;
             :     // Level.toLevel() returns DEBUG for an incorrect logLevel input.
             :    
> I think this can be removed, as far as I can see it was only called by the 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 08:00:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 11: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5959/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 11
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 14:21:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12: Code-Review+1

Thank you for the update ZoltanG. The WebUI and the change looks good to me this way! :)

Also, thank you for the review ZoltanB!


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 09:55:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG@9
PS6, Line 9: 
> nit: for log messages we use lines with 72 chars width.
Done


http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc
File be/src/util/logging-support.cc:

http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@143
PS6, Line 143: l
> nit:extra space
Done


http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@233
PS6, Line 233:     if (display_log4j_handlers) {GetJavaLogLevels(doc);}
             :     GetGlogLevel(doc);
             :   };
> nit: fits single line as well
Done


http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift
File common/thrift/Logging.thrift:

http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift@48
PS6, Line 48: log_level
> nit: we use underscores in member names, i.e. it should be log_levels
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 11:30:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6048/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 08:22:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5832/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 15:04:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5857/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 12:33:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5819/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 17:18:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#2).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching function.
Fetch glog level on every request which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format next to combo box
Show always default and current glog level on page.
Rename title from "Change Java log level" to "Change frontend logging level".

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M www/log_level.tmpl
2 files changed, 26 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5830/


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 14:53:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15903

to look at the new patch set (#6).

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................

IMPALA-8860: Improve /log_level usability on WebUI

Add glog level fetching logic and fetch glog level on every request which allows:
 - showing glog level on page load/reload
 - showing current glog level in "Log level" combo box
 - showing current glog level in text format

Add log4j log levels fetching logic and fetch all java class log levels on every request:
 -  log4j levels for all java classes previously set are shown on page as a list,
    fetching of individual class log levels not needed anymore

Page layout standardization:
 - glog/log4j part has similar layout
 - using terms of frontend/backend logs

Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
---
M be/src/util/logging-support.cc
M common/thrift/Logging.thrift
M fe/src/main/java/org/apache/impala/util/GlogAppender.java
M tests/webserver/test_web_pages.py
M www/log_level.tmpl
5 files changed, 109 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/15903/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5816/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 07:37:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5819/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 13:37:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6097/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 13:02:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 1:

(1 comment)

Hi Zoltan,
Thank you for submitting this change.

For web UI changes, I generally find it useful to attach screenshots to the JIRA of what exactly changed. It helps document things more clearly.

http://gerrit.cloudera.org:8080/#/c/15903/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15903/1//COMMIT_MSG@8
PS1, Line 8: 
Could you add a couple of sentences on what this change covers?



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 08:51:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 17:56:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5830/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 09:21:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2020 12:47:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12: Code-Review+2

LGTM! Thanks, Everyone!


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 11:47:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 5:

I have also added a screenshot in IMPALA-8860 Jira ticket about the current look of the web UI: proposed-webui-log-level-1.png


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 12:30:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15903/8/common/thrift/Logging.thrift
File common/thrift/Logging.thrift:

http://gerrit.cloudera.org:8080/#/c/15903/8/common/thrift/Logging.thrift@35
PS8, Line 35: // These are used as: 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/15903/8/common/thrift/Logging.thrift@38
PS8, Line 38: // - return value as a list of Java classes with corresponding 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 12:35:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6240/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 14:20:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 13: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 17:15:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 10:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6239/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:31:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Zoltan Garaguly (Code Review)" <ge...@cloudera.org>.
Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 1:

(1 comment)

Hi Mate,
I added screenshot proposed-webui-log-level.png to IMPALA-8860.

http://gerrit.cloudera.org:8080/#/c/15903/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15903/1//COMMIT_MSG@8
PS1, Line 8: 
> Could you add a couple of sentences on what this change covers?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 10:25:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5960/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:35:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5958/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 12:40:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )

Change subject: IMPALA-8860: Improve /log_level usability on WebUI
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5875/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33
Gerrit-Change-Number: 15903
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Garaguly <zg...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2020 07:26:05 +0000
Gerrit-HasComments: No