You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "fisjac (via GitHub)" <gi...@apache.org> on 2024/04/09 14:55:21 UTC
[PR] chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose [superset]
fisjac opened a new pull request, #27951:
URL: https://github.com/apache/superset/pull/27951
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The existing documentation for enabling a headless webdriver do not work for the environment when using docker compose. Updating the docs to suggest using WEBDRIVER_BASEURL = "https://superset_app:8088" when running in docker compose.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #27951:
URL: https://github.com/apache/superset/pull/27951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #27951:
URL: https://github.com/apache/superset/pull/27951#discussion_r1600503169
##########
docs/docs/configuration/alerts-reports.mdx:
##########
@@ -160,7 +160,7 @@ WEBDRIVER_OPTION_ARGS = [
]
# This is for internal use, you can keep http
-WEBDRIVER_BASEURL = "http://superset:8088"
+WEBDRIVER_BASEURL = "http://superset:8088" #When running using docker compose use "http://superset_app:8088'
Review Comment:
```suggestion
WEBDRIVER_BASEURL = "http://superset:8088" # When running using docker compose use "http://superset_app:8088'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #27951:
URL: https://github.com/apache/superset/pull/27951#issuecomment-2046046744
What about changing it here? -> https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py#L97-L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docs): updating alerts & reports documentation WEBDRIVER_BASEURL settings for docker compose [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #27951:
URL: https://github.com/apache/superset/pull/27951#discussion_r1558049160
##########
docs/docs/installation/alerts-reports.mdx:
##########
@@ -160,7 +160,7 @@ WEBDRIVER_OPTION_ARGS = [
]
# This is for internal use, you can keep http
-WEBDRIVER_BASEURL = "http://superset:8088"
+WEBDRIVER_BASEURL = "http://superset:8088" #When running using docker compose use "http://superset_app:8088'
Review Comment:
```suggestion
WEBDRIVER_BASEURL = "http://superset:8088" # When running using docker compose use "http://superset_app:8088"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org