You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2018/12/09 09:23:01 UTC
[GitHub] codecov-io commented on issue #359: KYLIN-3628 The wrong result
when a query with one lookup table
codecov-io commented on issue #359: KYLIN-3628 The wrong result when a query with one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-445522483
# [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=h1) Report
> Merging [#359](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/39878baa405385e850820838f86fcfe56a10b0ca?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #359 +/- ##
============================================
- Coverage 23.64% 23.62% -0.02%
- Complexity 4839 4840 +1
============================================
Files 1131 1131
Lines 68200 68235 +35
Branches 9685 9692 +7
============================================
- Hits 16123 16122 -1
- Misses 50509 50545 +36
Partials 1568 1568
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh) | `37.9% <0%> (ø)` | `50 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `38.47% <0%> (-1.92%)` | `44 <0> (ø)` | |
| [.../kylin/query/enumerator/LookupTableEnumerator.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L2VudW1lcmF0b3IvTG9va3VwVGFibGVFbnVtZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=footer). Last update [39878ba...a8cbcde](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services