You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/12 10:43:21 UTC

[GitHub] [flink] zentol commented on a diff in pull request #19427: [FLINK-27140][coordination] Write job result in ioExecutor

zentol commented on code in PR #19427:
URL: https://github.com/apache/flink/pull/19427#discussion_r848287320


##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -420,7 +420,7 @@ public void testCancellationOfCanceledTerminalDoesNotThrowException() throws Exc
                                         .build())));
 
         // wait for job to finish
-        dispatcherGateway.requestJobResult(jobId, TIMEOUT).get();
+        dispatcher.getJobTerminationFuture(jobId, TIMEOUT).get();

Review Comment:
   That's kinda covered by `testRequestMultipleJobDetails_returnsRunningOverSuspendedJob`; there one of the mock JMRunners doesn't terminate and implements the required methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org