You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/22 06:01:44 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #8205: feat: add request body to google-cloud-logging

spacewander commented on code in PR #8205:
URL: https://github.com/apache/apisix/pull/8205#discussion_r1055118788


##########
apisix/plugins/google-cloud-logging.lua:
##########
@@ -178,6 +180,7 @@ local function get_logger_entry(conf, ctx, oauth)
         jsonPayload = {
             route_id = entry.route_id,
             service_id = entry.service_id,
+            request_body = core.json.decode(entry.request.body),

Review Comment:
   We don't need to decode request body which is already a single string?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org