You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2024/10/17 15:29:07 UTC
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21953
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Removed the DCHECK assertion that tuple_data_len must be greater
than zero in tuple-file-writer.cc and tuple-file-reader.cc,
because in certain cases, such as count(*), tuple_data_len can
be zero, as no column data is returned and only the row count
matters.
Tests:
Adds TestTupleCacheCountStar for the regression test.
Change-Id: I264b537f0eb678b65081e90c21726198f254513d
---
M be/src/exec/tuple-file-reader.cc
M be/src/exec/tuple-file-writer.cc
M tests/custom_cluster/test_tuple_cache.py
3 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/21953/1
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17211/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 15:56:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11046/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 18:20:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Removed the DCHECK assertion that tuple_data_len must be greater
than zero in tuple-file-writer.cc and tuple-file-reader.cc,
because in certain cases, such as count(*), tuple_data_len can
be zero, as no column data is returned and only the row count
matters.
Tests:
Adds TestTupleCacheCountStar for the regression test.
Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Reviewed-on: http://gerrit.cloudera.org:8080/21953
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/tuple-file-reader.cc
M be/src/exec/tuple-file-writer.cc
M tests/custom_cluster/test_tuple_cache.py
3 files changed, 31 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 16:33:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 18:20:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 1: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 18:13:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Gerrit-Change-Number: 21953
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 23:25:39 +0000
Gerrit-HasComments: No