You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Doron Cohen (JIRA)" <ji...@apache.org> on 2007/06/23 08:16:25 UTC

[jira] Created: (LUCENE-940) SimpleDateFormat used in a non thread safe manner

SimpleDateFormat used in a non thread safe manner
-------------------------------------------------

                 Key: LUCENE-940
                 URL: https://issues.apache.org/jira/browse/LUCENE-940
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/benchmark
            Reporter: Doron Cohen
            Assignee: Doron Cohen
            Priority: Minor
             Fix For: 2.3


As Mike pointed out in http://www.mail-archive.com/java-dev@lucene.apache.org/msg10831.html SimpleDateFormat is not thread safe and hence DocMakers need to maintain it in a ThreadLocal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-940) SimpleDateFormat used in a non thread safe manner

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-940.
--------------------------------

    Resolution: Fixed

with LUCENE-945 resolved this one can be resolved as well (now the parabuild test pass).

> SimpleDateFormat used in a non thread safe manner
> -------------------------------------------------
>
>                 Key: LUCENE-940
>                 URL: https://issues.apache.org/jira/browse/LUCENE-940
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-940.patch
>
>
> As Mike pointed out in http://www.mail-archive.com/java-dev@lucene.apache.org/msg10831.html SimpleDateFormat is not thread safe and hence DocMakers need to maintain it in a ThreadLocal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Reopened: (LUCENE-940) SimpleDateFormat used in a non thread safe manner

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen reopened LUCENE-940:
--------------------------------


New test case TestPerfTasksLogic.testParallelDocMaker() is using Reuters collection, which is not found in this test run. Need to check why. Should have better tested the whole setup, not just the particular Test, sorry fore that.

> SimpleDateFormat used in a non thread safe manner
> -------------------------------------------------
>
>                 Key: LUCENE-940
>                 URL: https://issues.apache.org/jira/browse/LUCENE-940
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-940.patch
>
>
> As Mike pointed out in http://www.mail-archive.com/java-dev@lucene.apache.org/msg10831.html SimpleDateFormat is not thread safe and hence DocMakers need to maintain it in a ThreadLocal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-940) SimpleDateFormat used in a non thread safe manner

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-940.
--------------------------------

       Resolution: Fixed
    Lucene Fields: [Patch Available]  (was: [New])

Committed the fix, thanks Mike for tracking this!

> SimpleDateFormat used in a non thread safe manner
> -------------------------------------------------
>
>                 Key: LUCENE-940
>                 URL: https://issues.apache.org/jira/browse/LUCENE-940
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-940.patch
>
>
> As Mike pointed out in http://www.mail-archive.com/java-dev@lucene.apache.org/msg10831.html SimpleDateFormat is not thread safe and hence DocMakers need to maintain it in a ThreadLocal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-940) SimpleDateFormat used in a non thread safe manner

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-940:
-------------------------------

    Attachment: lucene-940.patch

Attached patch fixing DateFormat for parallel "doc making". 
Also fixing addDoc logging in this scenario.


> SimpleDateFormat used in a non thread safe manner
> -------------------------------------------------
>
>                 Key: LUCENE-940
>                 URL: https://issues.apache.org/jira/browse/LUCENE-940
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-940.patch
>
>
> As Mike pointed out in http://www.mail-archive.com/java-dev@lucene.apache.org/msg10831.html SimpleDateFormat is not thread safe and hence DocMakers need to maintain it in a ThreadLocal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org