You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/19 20:55:26 UTC

[GitHub] michellethomas opened a new pull request #3499: Add metric warning

michellethomas opened a new pull request #3499: Add metric warning
URL: https://github.com/apache/incubator-superset/pull/3499
 
 
   Addressing [this](https://github.com/apache/incubator-superset/issues/3389) issue, I added warning_text to BaseMetric and displayed it in MetricOption.
   
   I added javascript tests, but didn't see changes like this in python tests. Let me know if I should add python tests for this change.
   
   I tested locally:
   `superset db upgrade`
   added a warning message on a metric in a sql table
   confirmed the message showed up correctly
   tested `superset db downgrade`
   
   ![image](https://user-images.githubusercontent.com/817955/30612250-d0f244f2-9d38-11e7-8f4d-d8748d357bd5.png)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services