[GitHub] [doris] Bingandbing commented on a diff in pull request #18747: [Enhancement](Nereids)Add nereids minidump

["Bingandbing (via GitHub)" <gi...@apache.org>]

Bingandbing commented on code in PR #18747:
URL: https://github.com/apache/doris/pull/18747#discussion_r1178763839


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java:
##########
@@ -108,15 +110,21 @@ public CostAndEnforcerJob(GroupExpression groupExpression, JobContext context) {
      */
     @Override
     public void execute() {
+        CostCalculator.setEnableNewCostModel(

Review Comment:
   If we don't change this, minidump would not work properly cause of getting environment variables, this is the minimal change which minidump could work



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/CascadesContext.java:
##########
@@ -332,6 +336,21 @@ public void extractTables(LogicalPlan logicalPlan) {
         }
     }
 
+    /** get table by table name, try to get from information from dumpfile first */
+    public Table getTableByName(String tableName) {
+        assert (tables != null);

Review Comment:
   get



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org