You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/28 22:21:43 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9038:
Remove redirect endpoint /superset/explorev2
willbarrett opened a new pull request #9038: Remove redirect endpoint /superset/explorev2
URL: https://github.com/apache/incubator-superset/pull/9038
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The /superset/explorev2 redirect endpoint has been present for quite some time as a backwards-compatibility fix. It is unlikely that this endpoint is still in use.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [X] Removes existing feature or API
### REVIEWERS
@craig-rueda @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9038: Remove
redirect endpoint /superset/explorev2
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9038: Remove redirect endpoint /superset/explorev2
URL: https://github.com/apache/incubator-superset/pull/9038
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on issue #9038: Remove
redirect endpoint /superset/explorev2
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on issue #9038: Remove redirect endpoint /superset/explorev2
URL: https://github.com/apache/incubator-superset/pull/9038#issuecomment-579489956
LGTM, as long as others are fine with its removal :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9038: Remove
redirect endpoint /superset/explorev2
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9038: Remove redirect endpoint /superset/explorev2
URL: https://github.com/apache/incubator-superset/pull/9038#issuecomment-579523421
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=h1) Report
> Merging [#9038](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/162f81078ef5fd43ca182f734724d60bfbe99798?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9038 +/- ##
=======================================
Coverage 59.43% 59.43%
=======================================
Files 369 369
Lines 11743 11743
Branches 2884 2884
=======================================
Hits 6980 6980
Misses 4584 4584
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=footer). Last update [162f810...be8a121](https://codecov.io/gh/apache/incubator-superset/pull/9038?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #9038:
Remove redirect endpoint /superset/explorev2
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #9038: Remove redirect endpoint /superset/explorev2
URL: https://github.com/apache/incubator-superset/pull/9038#issuecomment-579561779
yes, this endpoint should be expired 2 years ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org