You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sashapolo (via GitHub)" <gi...@apache.org> on 2023/06/02 08:15:34 UTC

[GitHub] [ignite-3] sashapolo opened a new pull request, #2135: IGNITE-19452 Forbid placing Marshallable on some standard types

sashapolo opened a new pull request, #2135:
URL: https://github.com/apache/ignite-3/pull/2135

   https://issues.apache.org/jira/browse/IGNITE-19452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2135: IGNITE-19452 Forbid placing Marshallable on some standard types

Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #2135:
URL: https://github.com/apache/ignite-3/pull/2135#discussion_r1214212945


##########
.idea/inspectionProfiles/Project_Default.xml:
##########
@@ -1185,4 +1189,4 @@
       <option name="ADD_NONJAVA_TO_ENTRIES" value="true" />
     </inspection_tool>
   </profile>
-</component>
+</component>

Review Comment:
   Is this intentional? Or you committed the file by mistake?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] ibessonov merged pull request #2135: IGNITE-19452 Forbid placing Marshallable on some standard types

Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #2135:
URL: https://github.com/apache/ignite-3/pull/2135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2135: IGNITE-19452 Forbid placing Marshallable on some standard types

Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #2135:
URL: https://github.com/apache/ignite-3/pull/2135#discussion_r1214299907


##########
.idea/inspectionProfiles/Project_Default.xml:
##########
@@ -1185,4 +1189,4 @@
       <option name="ADD_NONJAVA_TO_ENTRIES" value="true" />
     </inspection_tool>
   </profile>
-</component>
+</component>

Review Comment:
   This is intentional, I removed the `assertEquals on itself` warning from inspections, but IDEA also decided to format all this additional stuff on its own 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org