You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "sclee01 (via GitHub)" <gi...@apache.org> on 2025/06/17 06:52:13 UTC
[PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
sclee01 opened a new pull request, #1905:
URL: https://github.com/apache/polaris/pull/1905
This PR addresses an inconsistency in bootstrap credential settings across various parts of the project.
It is originated from the following issue: [#1869](https://github.com/apache/polaris/issues/1869#issuecomment-2976500860)
## Previously:
### docker-compose.yml used:
`POLARIS_BOOTSTRAP_CREDENTIALS: default-realm,root,s3cr3t`
### whereas other configurations (e.g., gradle.properties, README examples) used:
`-Dpolaris.bootstrap.credentials=POLARIS,root,secret`
This inconsistency caused errors when running commands like `./regtests/run_spark_sql.sh.`
## Summary of Changes
Unified all credential formats to use `default-realm,root,s3cr3t`
Modified:
- gradle.properties
- docker-compose.yml
- README.md
- run_spark.sql.sh
This change ensures consistent local development setup across the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152895625
##########
client/python/integration_tests/conftest.py:
##########
@@ -133,7 +133,7 @@ def root_token(
client_id=client_id,
client_secret=client_secret,
grant_type="client_credentials",
- _headers={"realm": "default-realm"},
Review Comment:
Thanks for the unification, could you please also update the `polaris_root_credential` in this file to match the credentials in `docker-compose.yml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2983856145
> Thanks for your comment, @snazy . You're absolutely right that `default-realm` is more generic and descriptive.
Ah, bummer. Right, it's mentioned in the default configuration that way. Guess we have to live with `POLARIS` then.
But mind changing `secret` back to `s3cr3t` - I suspect that's better to figure out (code search).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152323891
##########
plugins/spark/v3.5/regtests/docker-compose.yml:
##########
@@ -25,7 +25,7 @@ services:
- "8182"
environment:
AWS_REGION: us-west-2
- POLARIS_BOOTSTRAP_CREDENTIALS: POLARIS,root,secret
+ POLARIS_BOOTSTRAP_CREDENTIALS: default-realm,root,s3cr3t
Review Comment:
I’ll go ahead and change it to POLARIS for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2153433994
##########
getting-started/jdbc/README.md:
##########
@@ -42,7 +42,7 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_PASSWORD=postgres
export ASSETS_PATH=$(pwd)/getting-started/assets/
export CLIENT_ID=root
- export CLIENT_SECRET=s3cr3t
+ export CLIENT_SECRET=secret
Review Comment:
I agreed with @dimas-b for the uniqueness, but the string `secret` was used in regression tests. To change it to something else will have a bigger impact on downstream projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2989730162
We’ve aligned on using `POLARIS,root,s3cr3t` for consistency and searchability. All files now reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152198370
##########
plugins/spark/v3.5/regtests/docker-compose.yml:
##########
@@ -25,7 +25,7 @@ services:
- "8182"
environment:
AWS_REGION: us-west-2
- POLARIS_BOOTSTRAP_CREDENTIALS: POLARIS,root,secret
+ POLARIS_BOOTSTRAP_CREDENTIALS: default-realm,root,s3cr3t
Review Comment:
@sclee01 I wonder if `POLARIS` isn't a better default, because that is the default realm defined in Polaris configuration:
https://github.com/apache/polaris/blob/23f6480054c389d9ea9414182b8e04f6f7de5586/quarkus/defaults/src/main/resources/application.properties#L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2986482047
Fixed CI failure caused by credential format mismatch. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2982251932
I’ve rechecked all related README files for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2983821577
Thanks for your comment, @snazy . You're absolutely right that `default-realm` is more generic and descriptive.
I originally used `default-realm,root,s3cr3t`, but updated it to `POLARIS,root,secret` following reviewer feedback — particularly the point that "POLARIS" is set as the default realm in Polaris configuration.
Would you be okay with updating the PR summary to reflect this, rather than reverting the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152323891
##########
plugins/spark/v3.5/regtests/docker-compose.yml:
##########
@@ -25,7 +25,7 @@ services:
- "8182"
environment:
AWS_REGION: us-west-2
- POLARIS_BOOTSTRAP_CREDENTIALS: POLARIS,root,secret
+ POLARIS_BOOTSTRAP_CREDENTIALS: default-realm,root,s3cr3t
Review Comment:
@adutra Updated to POLARIS for consistency — take a look when you can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2991843946
This PR moves all default / example credentials to `s3cr3t` as far as I can tell. I'm fine with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2984129482
All feedback has been applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152653157
##########
plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb:
##########
@@ -21,7 +21,7 @@
"from polaris.catalog.api_client import ApiClient as CatalogApiClient\n",
"from polaris.catalog.api_client import Configuration as CatalogApiClientConfiguration\n",
"\n",
- "polaris_credential = 'root:s3cr3t' # pragma: allowlist secret\n",
+ "polaris_credential = 'root:secret' # pragma: allowlist secret\n",
Review Comment:
I think you also need to modify line 36 below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2982306305
There are strings of `s3cr3t` in `BootstrapCommandTestBase`, but I think it's fine. We don't have to unify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2989656338
I'm having trouble figuring out the state of the PR based on what appear to be two conflicting comments:
* https://github.com/apache/polaris/pull/1905#discussion_r2153433994
* https://github.com/apache/polaris/pull/1905#issuecomment-2983856145
I don't have a preference between the two, but are we aligned on using `s3cr3t`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2983870102
Got it. I'll change `secret` back to `s3cr3t` so it's easier to search for. Thanks for pointing that out!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #1905:
URL: https://github.com/apache/polaris/pull/1905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2153012517
##########
getting-started/jdbc/README.md:
##########
@@ -42,7 +42,7 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_PASSWORD=postgres
export ASSETS_PATH=$(pwd)/getting-started/assets/
export CLIENT_ID=root
- export CLIENT_SECRET=s3cr3t
+ export CLIENT_SECRET=secret
Review Comment:
nit: I'm fine with this change, however the old `s3cr3t` was quite unique and easy to search for in text ;)
##########
getting-started/jdbc/README.md:
##########
@@ -42,7 +42,7 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_PASSWORD=postgres
export ASSETS_PATH=$(pwd)/getting-started/assets/
export CLIENT_ID=root
- export CLIENT_SECRET=s3cr3t
+ export CLIENT_SECRET=secret
Review Comment:
nit: I'm fine with this change, however the old `s3cr3t` string was quite unique and easy to search for in text ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2980728309
Thanks for your notice. I will check it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2980758369
> What about `getting-started/jdbc/docker-compose-bootstrap-db.yml`?
It seems all the Jupyter notebooks need to be changed (search for `SparkPolaris.ipynb`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unify bootstrap credentials format across docker-compose and Gradle [polaris]
Posted by "sclee01 (via GitHub)" <gi...@apache.org>.
sclee01 commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2152665596
##########
plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb:
##########
@@ -21,7 +21,7 @@
"from polaris.catalog.api_client import ApiClient as CatalogApiClient\n",
"from polaris.catalog.api_client import Configuration as CatalogApiClientConfiguration\n",
"\n",
- "polaris_credential = 'root:s3cr3t' # pragma: allowlist secret\n",
+ "polaris_credential = 'root:secret' # pragma: allowlist secret\n",
Review Comment:
Done! Line 36 and others are now fixed as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org