You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@concerted.apache.org by Atri Sharma <at...@gmail.com> on 2015/11/06 14:46:20 UTC
Tests and build processes
Hi All,
With CONCERTED-5 having been committed build process is following:
1) make
2) make check
For cleaning:
Make clean
Please ensure that make check succeeds before submitting your patch
Re: Tests and build processes
Posted by Atri Sharma <at...@gmail.com>.
Can you open a JIRA and point pull request there?
Also can you elaborate on CONCERTED-18 issue?
On 6 Nov 2015 19:42, "Gaurav Shukla" <gs...@gmail.com> wrote:
> It's not -lrt, I included unistd.h in ConcSegHashTable.cpp.
>
> Apart from that , It's says all test successfully passed while I can see
> some values not found. I think that's not normal.
>
> Also while I was making changes to ConcMAT.h [CONCERTED-18] I found some
> errors in search function i think these two issues are related.
>
> On Fri, Nov 6, 2015 at 7:25 PM, Gaurav Shukla <gs...@gmail.com> wrote:
>
> > ok ,on it
> >
> > On Fri, Nov 6, 2015 at 7:23 PM, Atri Sharma <at...@gmail.com> wrote:
> >
> >> Ugh, -lrt is missing in the makefile.
> >>
> >> Gaurav, could you please check? I am in a flight right now
> >> On 6 Nov 2015 19:22, "Gaurav Shukla" <gs...@gmail.com> wrote:
> >>
> >> > As of now make check fails with
> >> >
> >> > ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test(void*)’:
> >> > > ConcSegHashTableTest.cpp:27:10: error: ‘sleep’ was not declared in
> >> this
> >> > > scope
> >> > > sleep(1);
> >> > > ^
> >> > > ConcSegHashTableTest.cpp: In function ‘void*
> >> thread_lock_test2(void*)’:
> >> > > ConcSegHashTableTest.cpp:48:10: error: ‘sleep’ was not declared in
> >> this
> >> > > scope
> >> > > sleep(1);
> >> >
> >> >
> >> >
> >> > On Fri, Nov 6, 2015 at 7:16 PM, Atri Sharma <at...@gmail.com>
> >> wrote:
> >> >
> >> > > Hi All,
> >> > >
> >> > > With CONCERTED-5 having been committed build process is following:
> >> > >
> >> > > 1) make
> >> > > 2) make check
> >> > >
> >> > > For cleaning:
> >> > > Make clean
> >> > >
> >> > > Please ensure that make check succeeds before submitting your patch
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Regards !
> >> > Gaurav Shukla
> >> > gauravshukla.xyz
> >> > Phone: +91-837-584-7862
> >> >
> >>
> >
> >
> >
> > --
> > Regards !
> > Gaurav Shukla
> > gauravshukla.xyz
> > Phone: +91-837-584-7862
> >
>
>
>
> --
> Regards !
> Gaurav Shukla
> gauravshukla.xyz
> Phone: +91-837-584-7862
>
Re: Tests and build processes
Posted by Gaurav Shukla <gs...@gmail.com>.
It's not -lrt, I included unistd.h in ConcSegHashTable.cpp.
Apart from that , It's says all test successfully passed while I can see
some values not found. I think that's not normal.
Also while I was making changes to ConcMAT.h [CONCERTED-18] I found some
errors in search function i think these two issues are related.
On Fri, Nov 6, 2015 at 7:25 PM, Gaurav Shukla <gs...@gmail.com> wrote:
> ok ,on it
>
> On Fri, Nov 6, 2015 at 7:23 PM, Atri Sharma <at...@gmail.com> wrote:
>
>> Ugh, -lrt is missing in the makefile.
>>
>> Gaurav, could you please check? I am in a flight right now
>> On 6 Nov 2015 19:22, "Gaurav Shukla" <gs...@gmail.com> wrote:
>>
>> > As of now make check fails with
>> >
>> > ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test(void*)’:
>> > > ConcSegHashTableTest.cpp:27:10: error: ‘sleep’ was not declared in
>> this
>> > > scope
>> > > sleep(1);
>> > > ^
>> > > ConcSegHashTableTest.cpp: In function ‘void*
>> thread_lock_test2(void*)’:
>> > > ConcSegHashTableTest.cpp:48:10: error: ‘sleep’ was not declared in
>> this
>> > > scope
>> > > sleep(1);
>> >
>> >
>> >
>> > On Fri, Nov 6, 2015 at 7:16 PM, Atri Sharma <at...@gmail.com>
>> wrote:
>> >
>> > > Hi All,
>> > >
>> > > With CONCERTED-5 having been committed build process is following:
>> > >
>> > > 1) make
>> > > 2) make check
>> > >
>> > > For cleaning:
>> > > Make clean
>> > >
>> > > Please ensure that make check succeeds before submitting your patch
>> > >
>> >
>> >
>> >
>> > --
>> > Regards !
>> > Gaurav Shukla
>> > gauravshukla.xyz
>> > Phone: +91-837-584-7862
>> >
>>
>
>
>
> --
> Regards !
> Gaurav Shukla
> gauravshukla.xyz
> Phone: +91-837-584-7862
>
--
Regards !
Gaurav Shukla
gauravshukla.xyz
Phone: +91-837-584-7862
Re: Tests and build processes
Posted by Gaurav Shukla <gs...@gmail.com>.
ok ,on it
On Fri, Nov 6, 2015 at 7:23 PM, Atri Sharma <at...@gmail.com> wrote:
> Ugh, -lrt is missing in the makefile.
>
> Gaurav, could you please check? I am in a flight right now
> On 6 Nov 2015 19:22, "Gaurav Shukla" <gs...@gmail.com> wrote:
>
> > As of now make check fails with
> >
> > ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test(void*)’:
> > > ConcSegHashTableTest.cpp:27:10: error: ‘sleep’ was not declared in this
> > > scope
> > > sleep(1);
> > > ^
> > > ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test2(void*)’:
> > > ConcSegHashTableTest.cpp:48:10: error: ‘sleep’ was not declared in this
> > > scope
> > > sleep(1);
> >
> >
> >
> > On Fri, Nov 6, 2015 at 7:16 PM, Atri Sharma <at...@gmail.com> wrote:
> >
> > > Hi All,
> > >
> > > With CONCERTED-5 having been committed build process is following:
> > >
> > > 1) make
> > > 2) make check
> > >
> > > For cleaning:
> > > Make clean
> > >
> > > Please ensure that make check succeeds before submitting your patch
> > >
> >
> >
> >
> > --
> > Regards !
> > Gaurav Shukla
> > gauravshukla.xyz
> > Phone: +91-837-584-7862
> >
>
--
Regards !
Gaurav Shukla
gauravshukla.xyz
Phone: +91-837-584-7862
Re: Tests and build processes
Posted by Atri Sharma <at...@gmail.com>.
Ugh, -lrt is missing in the makefile.
Gaurav, could you please check? I am in a flight right now
On 6 Nov 2015 19:22, "Gaurav Shukla" <gs...@gmail.com> wrote:
> As of now make check fails with
>
> ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test(void*)’:
> > ConcSegHashTableTest.cpp:27:10: error: ‘sleep’ was not declared in this
> > scope
> > sleep(1);
> > ^
> > ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test2(void*)’:
> > ConcSegHashTableTest.cpp:48:10: error: ‘sleep’ was not declared in this
> > scope
> > sleep(1);
>
>
>
> On Fri, Nov 6, 2015 at 7:16 PM, Atri Sharma <at...@gmail.com> wrote:
>
> > Hi All,
> >
> > With CONCERTED-5 having been committed build process is following:
> >
> > 1) make
> > 2) make check
> >
> > For cleaning:
> > Make clean
> >
> > Please ensure that make check succeeds before submitting your patch
> >
>
>
>
> --
> Regards !
> Gaurav Shukla
> gauravshukla.xyz
> Phone: +91-837-584-7862
>
Re: Tests and build processes
Posted by Gaurav Shukla <gs...@gmail.com>.
As of now make check fails with
ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test(void*)’:
> ConcSegHashTableTest.cpp:27:10: error: ‘sleep’ was not declared in this
> scope
> sleep(1);
> ^
> ConcSegHashTableTest.cpp: In function ‘void* thread_lock_test2(void*)’:
> ConcSegHashTableTest.cpp:48:10: error: ‘sleep’ was not declared in this
> scope
> sleep(1);
On Fri, Nov 6, 2015 at 7:16 PM, Atri Sharma <at...@gmail.com> wrote:
> Hi All,
>
> With CONCERTED-5 having been committed build process is following:
>
> 1) make
> 2) make check
>
> For cleaning:
> Make clean
>
> Please ensure that make check succeeds before submitting your patch
>
--
Regards !
Gaurav Shukla
gauravshukla.xyz
Phone: +91-837-584-7862