You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/06 01:48:00 UTC
[jira] [Work logged] (BEAM-11572) Use MatcherAssert#assertThat
instead of deprecated Assert#assertThat
[ https://issues.apache.org/jira/browse/BEAM-11572?focusedWorklogId=531621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531621 ]
ASF GitHub Bot logged work on BEAM-11572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 01:47
Start Date: 06/Jan/21 01:47
Worklog Time Spent: 10m
Work Description: anantdamle opened a new pull request #13673:
URL: https://github.com/apache/beam/pull/13673
JUnit [`Assert#assertThat`](https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat(T,%20org.hamcrest.Matcher)) has is deprecated and needs to be replaced across entire codebase with [`MatcherAssert#assertThat`](https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat(T,%20org.hamcrest.Matcher)) as per recommendation.
@iemejia Thanks for reviewing my previous PRs. This is a massive PR, but few line changes in each file. how should I proceed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 531621)
Remaining Estimate: 0h
Time Spent: 10m
> Use MatcherAssert#assertThat instead of deprecated Assert#assertThat
> --------------------------------------------------------------------
>
> Key: BEAM-11572
> URL: https://issues.apache.org/jira/browse/BEAM-11572
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Affects Versions: 2.26.0
> Reporter: Anant Damle
> Assignee: Anant Damle
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Beam tests uses *deprecated* [Assert#assertThat|https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat(T,%20org.hamcrest.Matcher)] which needs to be changed to [MatcherAssert#assertThat|https://junit.org/junit4/javadoc/latest/org/hamcrest/MatcherAssert.html#assertThat(T,%20org.hamcrest.Matcher)]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)