You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/11 16:44:00 UTC
[jira] [Commented] (GEODE-2998) New flow: remove
[ https://issues.apache.org/jira/browse/GEODE-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082494#comment-16082494 ]
ASF GitHub Bot commented on GEODE-2998:
---------------------------------------
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/624
GEODE-2998: Add remove operation
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
GEODE-2998
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
does not apply
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-amurmann/geode GEODE-2998
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #624
----
commit bd1844d95d106d13328756dfeaea5f7731e0a089
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-07-06T23:36:51Z
GEODE-2998: Add remove operation
Signed-off-by: Alexander Murmann <am...@pivotal.io>
Signed-off-by: Matt Kalinowski <mk...@pivotal.io>
----
> New flow: remove
> ----------------
>
> Key: GEODE-2998
> URL: https://issues.apache.org/jira/browse/GEODE-2998
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Brian Baynes
>
> Create proto message definitions and op handler for remove message.
> Client should be able to complete remove with response.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)