You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by maropu <gi...@git.apache.org> on 2017/01/23 09:28:59 UTC
[GitHub] incubator-hivemall pull request #24: [HIVEMALL-32] Print explicit error mess...
GitHub user maropu opened a pull request:
https://github.com/apache/incubator-hivemall/pull/24
[HIVEMALL-32] Print explicit error messages in building xgboost with clang
## What changes were proposed in this pull request?
This pr modified code to print explicit error messages if you use `clang` and invoke `mvn -Pcompile-xgboost`.
## How was this patch tested?
Manually checked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/incubator-hivemall CheckCompiler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit f623a6aca7766f98ad7a4c29578611dfa486cfcd
Author: Takeshi YAMAMURO <li...@gmail.com>
Date: 2017-01-23T08:33:43Z
Check if a installed compiler is valid
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #24: [HIVEMALL-32] Print explicit error messages in...
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/24
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall pull request #24: [HIVEMALL-32] Print explicit error mess...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #24: [HIVEMALL-32] Print explicit error messages in...
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/24
LGTM. Could you update ASF master as follows:
```
git checkout master
git checkout -b CheckCompiler
git pull https://github.com/maropu/incubator-hivemall.git hotfix/CheckCompiler
git log | grep "Author" | head -1
git checkout master
git merge --squash hotfix/CheckCompiler
git commit -a --author="Takeshi Yamamuro <fo...@me.com>" --message="Close #24: Print explicit error messages in building xgboost with clang"
git push origin master
```
Note that it assumes that `origin` is https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #24: [HIVEMALL-32] Print explicit error messages in...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/24
[](https://coveralls.io/builds/9794571)
Coverage decreased (-0.02%) to 35.826% when pulling **f623a6aca7766f98ad7a4c29578611dfa486cfcd on maropu:CheckCompiler** into **d95f1e79daa421d738bfe9e6dcc76c7230013406 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---