You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (Created) (JIRA)" <ji...@apache.org> on 2012/04/13 13:35:16 UTC
[jira] [Created] (SOLR-3357) Add Generics to
ResourceLoader.newInstance
Add Generics to ResourceLoader.newInstance
------------------------------------------
Key: SOLR-3357
URL: https://issues.apache.org/jira/browse/SOLR-3357
Project: Solr
Issue Type: Improvement
Reporter: Chris Male
Came out of LUCENE-2510.
We can add generics to ResourceLoader.newInstance so it returns T instead of Object. This will add improved type safety and remove the need for casting the result to a specific type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3357) Add Generics to
ResourceLoader.newInstance
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253309#comment-13253309 ]
Uwe Schindler commented on SOLR-3357:
-------------------------------------
String +1 from the policeman, you made my weekend!
> Add Generics to ResourceLoader.newInstance
> ------------------------------------------
>
> Key: SOLR-3357
> URL: https://issues.apache.org/jira/browse/SOLR-3357
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Attachments: SOLR-3357.patch
>
>
> Came out of LUCENE-2510.
> We can add generics to ResourceLoader.newInstance so it returns T instead of Object. This will add improved type safety and remove the need for casting the result to a specific type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3357) Add Generics to
ResourceLoader.newInstance
Posted by "Chris Male (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved SOLR-3357.
------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Fixed in trunk.
> Add Generics to ResourceLoader.newInstance
> ------------------------------------------
>
> Key: SOLR-3357
> URL: https://issues.apache.org/jira/browse/SOLR-3357
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: SOLR-3357.patch
>
>
> Came out of LUCENE-2510.
> We can add generics to ResourceLoader.newInstance so it returns T instead of Object. This will add improved type safety and remove the need for casting the result to a specific type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3357) Add Generics to
ResourceLoader.newInstance
Posted by "Chris Male (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated SOLR-3357:
-----------------------------
Attachment: SOLR-3357.patch
Patch which adds generics to ResourceLoader.newInstance.
As part of this effort, I've had to clean up a lot of missing generics, removing Object return types instead of actual typed returns.
DIH wraps ResourceLoader.newInstance into its own newInstance like method which I've left untouched (using Object.class). It can be improved in a separate issue.
> Add Generics to ResourceLoader.newInstance
> ------------------------------------------
>
> Key: SOLR-3357
> URL: https://issues.apache.org/jira/browse/SOLR-3357
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Attachments: SOLR-3357.patch
>
>
> Came out of LUCENE-2510.
> We can add generics to ResourceLoader.newInstance so it returns T instead of Object. This will add improved type safety and remove the need for casting the result to a specific type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3357) Add Generics to
ResourceLoader.newInstance
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253505#comment-13253505 ]
Ryan McKinley commented on SOLR-3357:
-------------------------------------
+1
> Add Generics to ResourceLoader.newInstance
> ------------------------------------------
>
> Key: SOLR-3357
> URL: https://issues.apache.org/jira/browse/SOLR-3357
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Attachments: SOLR-3357.patch
>
>
> Came out of LUCENE-2510.
> We can add generics to ResourceLoader.newInstance so it returns T instead of Object. This will add improved type safety and remove the need for casting the result to a specific type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org