You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/02/26 06:41:55 UTC
Re: Review Request 30706: SENTRY-638: Improve test cases in
"TestSentryStore"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30706/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 5:41 a.m.)
Review request for sentry.
Summary (updated)
-----------------
SENTRY-638: Improve test cases in "TestSentryStore"
Repository: sentry
Description
-------
Improve test cases in "TestSentryStore"
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 136dab6
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 8fbe3f4
Diff: https://reviews.apache.org/r/30706/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 30706: SENTRY-638: Improve test cases in
"TestSentryStore"
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30706/#review74224
-----------------------------------------------------------
Ship it!
+1, LGTM. Thank Colin for the improvement
- Dapeng Sun
On 二月 26, 2015, 1:41 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30706/
> -----------------------------------------------------------
>
> (Updated 二月 26, 2015, 1:41 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Improve test cases in "TestSentryStore"
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 136dab6
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 8fbe3f4
>
> Diff: https://reviews.apache.org/r/30706/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>