You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/05/21 17:27:24 UTC
[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
wujimin opened a new pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
wujimin commented on a change in pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#discussion_r429006729
##########
File path: swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.swagger.invocation.exception;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+import io.vertx.core.json.Json;
+
+class CommonExceptionDataTest {
+ @Test
+ void should_not_include_code_in_json_when_code_is_null() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_code_in_json_when_code_is_not_null() {
+ CommonExceptionData data = new CommonExceptionData("code", "msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"code\":\"code\",\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_dynamic_field_in_json() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+ data.putDynamic("k", "v");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\",\"k\":\"v\"}");
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#discussion_r428995047
##########
File path: swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.swagger.invocation.exception;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+import io.vertx.core.json.Json;
+
+class CommonExceptionDataTest {
+ @Test
+ void should_not_include_code_in_json_when_code_is_null() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_code_in_json_when_code_is_not_null() {
+ CommonExceptionData data = new CommonExceptionData("code", "msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"code\":\"code\",\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_dynamic_field_in_json() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+ data.putDynamic("k", "v");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\",\"k\":\"v\"}");
Review comment:
Great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#issuecomment-632259515
[](https://coveralls.io/builds/30959807)
Coverage decreased (-0.02%) to 84.592% when pulling **362bda0514daf7257704eaa4671ebb070dd16117 on wujimin:SCB-1926-enhance-CommonExceptionData** into **b78c6671f61b2c2e5515bd15548a7a674ecaf58f on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#issuecomment-632259515
[](https://coveralls.io/builds/30951011)
Coverage decreased (-0.02%) to 84.592% when pulling **c1f2ef2765bbc4cd3e0320e317b138267a24ca24 on wujimin:SCB-1926-enhance-CommonExceptionData** into **b78c6671f61b2c2e5515bd15548a7a674ecaf58f on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
wujimin commented on a change in pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#discussion_r428994524
##########
File path: swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.swagger.invocation.exception;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+import io.vertx.core.json.Json;
+
+class CommonExceptionDataTest {
+ @Test
+ void should_not_include_code_in_json_when_code_is_null() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_code_in_json_when_code_is_not_null() {
+ CommonExceptionData data = new CommonExceptionData("code", "msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"code\":\"code\",\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_dynamic_field_in_json() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+ data.putDynamic("k", "v");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\",\"k\":\"v\"}");
Review comment:
yes, i'll add one case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770#discussion_r428992801
##########
File path: swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.swagger.invocation.exception;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+import io.vertx.core.json.Json;
+
+class CommonExceptionDataTest {
+ @Test
+ void should_not_include_code_in_json_when_code_is_null() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_code_in_json_when_code_is_not_null() {
+ CommonExceptionData data = new CommonExceptionData("code", "msg");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"code\":\"code\",\"message\":\"msg\"}");
+ }
+
+ @Test
+ void should_include_dynamic_field_in_json() {
+ CommonExceptionData data = new CommonExceptionData("msg");
+ data.putDynamic("k", "v");
+
+ assertThat(Json.encode(data)).isEqualTo("{\"message\":\"msg\",\"k\":\"v\"}");
Review comment:
Can '{\"message\":\"msg\",\"k\":\"v\"}' decode to the same data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1770: [SCB-1926] enhance CommonExceptionData to include more common data
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1770:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org