You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/10 05:46:47 UTC
[GitHub] [rocketmq] 916669644 opened a new issue #2994: 异步发送demo里的CountDownLatch2 的减数问题
916669644 opened a new issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994
问题地址:https://github.com/apache/rocketmq/blob/master/docs/cn/RocketMQ_Example.md#2%E5%8F%91%E9%80%81%E5%BC%82%E6%AD%A5%E6%B6%88%E6%81%AF
这里定义了一个CountDownLatch2 但是没有发现有减数操作,看到这里用是countDownLatch.await(5, TimeUnit.SECONDS);如果初衷只是休眠5秒,我想您应该会用TimeUnit.SECONDS.sleep(5);这样更简洁明了的操作吧,所以这里大胆猜测您是为了更好的满足性能,您这里是不是缺少了减数操作呢?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zongtanghu commented on issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-866480788
@zyh-future You can put forward a pr to fix this issues, and look forward you pr!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zplovekq commented on issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
zplovekq commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-866748438
hello , i check the doc.
the English version http://rocketmq.apache.org/docs/simple-example/ , at the `onsuccess()` method, you can see
`countDownLatch.countDown();`
but the chinese version you see before has not , missing that line of code.
I will push a pr for it sooner...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] 916669644 closed issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
916669644 closed issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyh-future commented on issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
zyh-future commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-866924945
OK, thank you
------------------ 原始邮件 ------------------
发件人: "apache/rocketmq" ***@***.***>;
发送时间: 2021年6月23日(星期三) 晚上7:14
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/rocketmq] RocketMQ Async Producer sample Polish (#2994)
hello , i check the doc.
the English version http://rocketmq.apache.org/docs/simple-example/ , at the onsuccess() method, you can see
countDownLatch.countDown();
but the chinese version you see before has not , missing that line of code.
I will push a pr for it sooner...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyh-future closed issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
zyh-future closed issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-861412202
@916669644 非常好的建议，欢迎提PR优化一下这个example，不仅仅是文档，也包括example 里面的代码
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyh-future commented on issue #2994: RocketMQ Async Producer sample Polish
Posted by GitBox <gi...@apache.org>.
zyh-future commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-866975916
作为一个刚毕业一年的毕业生本身对提pr比较抗拒，因为总觉得大佬被我这样的小兵子提意见不好，所以只是提了个issues没下一步了。但是后面 @duhenglucky @zongtanghu 都让我提个pr。现在也被采纳合并了，太感谢你们了，这让我这个小兵感觉技术圈真的很open，这让我超级开心 ！谢谢！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] francisoliverlee commented on issue #2994: 异步发送demo里的CountDownLatch2 的减数问题
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on issue #2994:
URL: https://github.com/apache/rocketmq/issues/2994#issuecomment-859208589
you can try it, check result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org