You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@continuum.apache.org by "Jevica Arianne B. Zurbano (JIRA)" <ji...@codehaus.org> on 2008/08/22 13:24:26 UTC

[jira] Created: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Build Failure with Multimodule project - with flat file structure
-----------------------------------------------------------------

                 Key: CONTINUUM-1850
                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
             Project: Continuum
          Issue Type: Bug
          Components: Core system
    Affects Versions: 1.2
            Reporter: Jevica Arianne B. Zurbano


Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.

Project structure is:

  parent-project
    '-- pom.xml
  module1
    '-- pom.xml
  module2
    '-- pom.xml
  module3
    '-- pom.xml


Modules are included in the parent-project\pom.xml.

relativePath of parent-project is specified in the child POMs.


This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Napoleon Esmundo C. Ramirez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145756#action_145756 ] 

nramirez edited comment on CONTINUUM-1850 at 8/22/08 11:05 AM:
----------------------------------------------------------------------------------

Building the parent project without the "-- batch-mode -- non-recursive" argument in the build definition will fail as expected, because maven will look for <module>../module1</module> that doesn't exist.  Though the submodules were checked out and added into continuum successfully, those will not be related to the parent project--not just because the submodules weren't checked out in the same scm tree as the parent (directories are named as project id's by continuum), but also because the ProjectBuilder handles projects individually and isolated from each other in a flat filesystem hierarchy.

And I really don't know if using that kind of project layout is a recommended practice.  It even causes issues in the release, as stated in CONTINUUM-1569.  For me, I'd rather follow:

{noformat}
project
|--pom.xml
|--module1
|   '--pom.xml
|--module2
|   '--pom.xml
'--module3
    '-- pom.xml
{noformat}

If not attainable in the filesystem, I'll do it in the scm via svn:externals just to form that kind of layout.

Just my thoughts.
Nap

      was (Author: nramirez):
    Building the parent project without the "-- batch-mode -- non-recursive" argument in the build definition will fail as expected, because maven will look for <module>../module1</module> that doesn't exist.  Though the submodules were checked out and added into continuum successfully, those will not be related to the parent project--not just because the submodules weren't checked out in the same scm tree as the parent (directories are named as project id's by continuum), but also because the ProjectBuilder handles projects individually and isolated from each other in a flat filesystem hierarchy.

And I really don't know if using that kind of project layout is a recommended practice.  It even causes issues in the release, as stated in CONTINUUM-1569.  For me, I'd rather follow:

project
|--pom.xml
|--module1
|   '--pom.xml
|--module2
|   '--pom.xml
'--module3
    '-- pom.xml

If not attainable in the filesystem, I'll do it in the scm via svn:externals just to form that kind of layout.

Just my thoughts.
Nap
  
> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wendy Smoak closed CONTINUUM-1850.
----------------------------------

      Assignee: Wendy Smoak
    Resolution: Cannot Reproduce

I can't reproduce this with the final release of Continuum 1.2.

I've added an example project to the sandbox:
http://svn.apache.org/repos/asf/continuum/sandbox/flat-example/

The project has a flat structure and an inter-module dependency.  I intentionally listed the modules in the wrong order in the parent pom.

I added the project to Continuum using the url to flat-parent/pom.xml.  All three modules were added.  

I forced a build of the group, and the modules were built in the correct order (parent, then jar, then webapp which depends on jar.)

Releasing the group does *not* work, but that's a different issue. (CONTINUUM-1569)

> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>            Assignee: Wendy Smoak
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Napoleon Esmundo C. Ramirez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145756#action_145756 ] 

Napoleon Esmundo C. Ramirez commented on CONTINUUM-1850:
--------------------------------------------------------

Building the parent project without the "--batch-mode --non-recursive" argument in the build definition will fail as expected, because maven will look for <module>../module1</module> that doesn't exist.  Though the submodules were checked out and added into continuum successfully, those will not be related to the parent project--not just because the submodules weren't checked out in the same scm tree as the parent (directories are named as project id's by continuum), but also because the ProjectBuilder handles projects individually and isolated from each other in a flat filesystem hierarchy.

And I really don't know if using that kind of project layout is a recommended practice.  It even causes issues in the release, as stated in CONTINUUM-1569.  For me, I'd rather follow:

project
|--pom.xml
|--module1
|   '--pom.xml
|--module2
|   '--pom.xml
'--module3
    '-- pom.xml

If not attainable in the filesystem, I'll do it in the scm via svn:externals just to form that kind of layout.

Just my thoughts.
Nap

> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Napoleon Esmundo C. Ramirez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145888#action_145888 ] 

Napoleon Esmundo C. Ramirez commented on CONTINUUM-1850:
--------------------------------------------------------

So it seems that removing --non-recursive doesn't make sense in this kind of structure.

There are lots of issues reporting the wrong build order of the projects in a project group.  Currently in Continuum's implementation, building all the projects in a project group will queue the projects in the build queue, with the order defined by the dependency relationships and by the build state.  I'd like to suggest using a persistent backing queue for a multi-module project that is defined upon adding it in Continuum.  This will serve as a backbone for that group's build that will ensure that the build order will stay as it was at the time it was added.


> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Jevica Arianne B. Zurbano (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145754#action_145754 ] 

Jevica Arianne B. Zurbano commented on CONTINUUM-1850:
------------------------------------------------------

Build Failure is encountered when building the parent project without the "--batch-mode --non-recursive" argument in the build definition.

> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Napoleon Esmundo C. Ramirez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145756#action_145756 ] 

nramirez edited comment on CONTINUUM-1850 at 8/22/08 11:04 AM:
----------------------------------------------------------------------------------

Building the parent project without the "-- batch-mode -- non-recursive" argument in the build definition will fail as expected, because maven will look for <module>../module1</module> that doesn't exist.  Though the submodules were checked out and added into continuum successfully, those will not be related to the parent project--not just because the submodules weren't checked out in the same scm tree as the parent (directories are named as project id's by continuum), but also because the ProjectBuilder handles projects individually and isolated from each other in a flat filesystem hierarchy.

And I really don't know if using that kind of project layout is a recommended practice.  It even causes issues in the release, as stated in CONTINUUM-1569.  For me, I'd rather follow:

project
|--pom.xml
|--module1
|   '--pom.xml
|--module2
|   '--pom.xml
'--module3
    '-- pom.xml

If not attainable in the filesystem, I'll do it in the scm via svn:externals just to form that kind of layout.

Just my thoughts.
Nap

      was (Author: nramirez):
    Building the parent project without the "--batch-mode --non-recursive" argument in the build definition will fail as expected, because maven will look for <module>../module1</module> that doesn't exist.  Though the submodules were checked out and added into continuum successfully, those will not be related to the parent project--not just because the submodules weren't checked out in the same scm tree as the parent (directories are named as project id's by continuum), but also because the ProjectBuilder handles projects individually and isolated from each other in a flat filesystem hierarchy.

And I really don't know if using that kind of project layout is a recommended practice.  It even causes issues in the release, as stated in CONTINUUM-1569.  For me, I'd rather follow:

project
|--pom.xml
|--module1
|   '--pom.xml
|--module2
|   '--pom.xml
'--module3
    '-- pom.xml

If not attainable in the filesystem, I'll do it in the scm via svn:externals just to form that kind of layout.

Just my thoughts.
Nap
  
> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145840#action_145840 ] 

Wendy Smoak commented on CONTINUUM-1850:
----------------------------------------

I don't expect --non-recursive to work because there's nothing checked out 'underneath' the parent pom.

But I do expect Continuum to be able to build the entire project group and figure out the correct order.

This "flat" structure is a typical of Eclipse projects, and is supported by Maven at the command line.


> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1850) Build Failure with Multimodule project - with flat file structure

Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145889#action_145889 ] 

Wendy Smoak commented on CONTINUUM-1850:
----------------------------------------

What if I add or remove some dependencies on other modules within the project?  The order has to be determined each time, at build time, just like it is when you type 'mvn install' at the command line.

> Build Failure with Multimodule project - with flat file structure
> -----------------------------------------------------------------
>
>                 Key: CONTINUUM-1850
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1850
>             Project: Continuum
>          Issue Type: Bug
>          Components: Core system
>    Affects Versions: 1.2
>            Reporter: Jevica Arianne B. Zurbano
>
> Building a multi-module project with flat file structure works fine in command line, but when hosted in Continuum, it's failing.
> Project structure is:
>   parent-project
>     '-- pom.xml
>   module1
>     '-- pom.xml
>   module2
>     '-- pom.xml
>   module3
>     '-- pom.xml
> Modules are included in the parent-project\pom.xml.
> relativePath of parent-project is specified in the child POMs.
> This issue is related to http://jira.codehaus.org/browse/CONTINUUM-1569.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira