[GitHub] [spark] wypoon commented on a change in pull request #35559: [SPARK-33206][CORE] Fix shuffle index cache weight calculation for small index files

[GitBox <gi...@apache.org>]

wypoon commented on a change in pull request #35559:
URL: https://github.com/apache/spark/pull/35559#discussion_r813436289



##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -40,7 +40,7 @@ public static File getFile(String[] localDirs, int subDirsPerLocalDir, String fi
     // So we are creating a File just to get the normalized path back to intern it.
     // Finally a new File is built and returned with this interned normalized path.

Review comment:
       Update the comment so it won't cause confusion.
   "Finally a new File is built and returned with this interned normalized path." -> "We return this interned normalized path."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org