You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by GitBox <gi...@apache.org> on 2020/11/23 22:28:06 UTC
[GitHub] [whimsy] sebbASF opened a new issue #108: Should '=' be '==' ?
sebbASF opened a new issue #108:
URL: https://github.com/apache/whimsy/issues/108
https://github.com/apache/whimsy/blob/2ad1a7972e9e43744abc04497208b9fb04a4b310/lib/whimsy/asf/rack.rb#L153
@rubys The operator here looks odd.
Is it supposed to be equality rather than assignment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] sebbASF commented on issue #108: Should '=' be '==' ?
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #108:
URL: https://github.com/apache/whimsy/issues/108#issuecomment-732488062
Do you mean assignment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] rubys commented on issue #108: Should '=' be '==' ?
Posted by GitBox <gi...@apache.org>.
rubys commented on issue #108:
URL: https://github.com/apache/whimsy/issues/108#issuecomment-732489537
Yes, I meant the assignment operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] rubys commented on issue #108: Should '=' be '==' ?
Posted by GitBox <gi...@apache.org>.
rubys commented on issue #108:
URL: https://github.com/apache/whimsy/issues/108#issuecomment-732479079
This is supposed to be equality. Follow the link in the comment on line 150 to see the original code. Perhaps adding parens or splitting in two lines will placate whatever linter you are using?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] asfgit closed issue #108: Should '=' be '==' ?
Posted by GitBox <gi...@apache.org>.
asfgit closed issue #108:
URL: https://github.com/apache/whimsy/issues/108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org