You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2012/06/25 10:46:30 UTC
svn commit: r1353433 - in /lucene/dev/trunk/lucene/core/src:
java/org/apache/lucene/index/DocumentsWriterFlushControl.java
java/org/apache/lucene/index/DocumentsWriterStallControl.java
test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
Author: simonw
Date: Mon Jun 25 08:46:29 2012
New Revision: 1353433
URL: http://svn.apache.org/viewvc?rev=1353433&view=rev
Log:
LUCENE-4158: leave stall control on each wakeup call to prevent full flush starvation due to queued flushes
Modified:
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterStallControl.java
lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java?rev=1353433&r1=1353432&r2=1353433&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java Mon Jun 25 08:46:29 2012
@@ -633,7 +633,13 @@ final class DocumentsWriterFlushControl
* checked out DWPT are available
*/
void waitIfStalled() {
- stallControl.waitIfStalled();
+ if (documentsWriter.infoStream.isEnabled("DWFC")) {
+ documentsWriter.infoStream.message("DWFC",
+ "waitIfStalled: numFlushesPending: " + flushQueue.size()
+ + " netBytes: " + netBytes() + " flushBytes: " + flushBytes()
+ + " fullFlush: " + fullFlush);
+ }
+ stallControl.waitIfStalled();
}
/**
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterStallControl.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterStallControl.java?rev=1353433&r1=1353432&r2=1353433&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterStallControl.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterStallControl.java Mon Jun 25 08:46:29 2012
@@ -67,17 +67,16 @@ final class DocumentsWriterStallControl
void waitIfStalled() {
if (stalled) {
synchronized (this) {
- boolean hasWaited = false;
- while (stalled) {
+ if (stalled) { // react on the first wakeup call!
+ // don't loop here, higher level logic will re-stall!
try {
- assert hasWaited || incWaiters();
- assert (hasWaited = true);
+ assert incWaiters();
wait();
+ assert decrWaiters();
} catch (InterruptedException e) {
throw new ThreadInterruptedException(e);
}
}
- assert !hasWaited || decrWaiters();
}
}
}
Modified: lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java?rev=1353433&r1=1353432&r2=1353433&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java (original)
+++ lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java Mon Jun 25 08:46:29 2012
@@ -63,7 +63,6 @@ public class TestDocumentsWriterStallCon
Thread[] stallThreads = new Thread[atLeast(3)];
for (int i = 0; i < stallThreads.length; i++) {
- final int threadId = i;
final int stallProbability = 1 +random().nextInt(10);
stallThreads[i] = new Thread() {
public void run() {