[jira] [Commented] (HDDS-2966) ACL checks should be done after acquiring lock

["YiSheng Lien (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028119#comment-17028119 ] 

YiSheng Lien commented on HDDS-2966:
------------------------------------

Hi [~hanishakoneru], thanks for the report.
Could I say the race condition is caused by DB operations ? (or other cause would you tell me)

> ACL checks should be done after acquiring lock
> ----------------------------------------------
>
>                 Key: HDDS-2966
>                 URL: https://issues.apache.org/jira/browse/HDDS-2966
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: HA
>            Reporter: Hanisha Koneru
>            Priority: Major
>
> Currently in OMClientRequests#validateAndUpdateCache, we perform ACL checks before acquiring the required object lock. This could lead to race condition. The ACL check should be done after acquiring the lock.
> For example, in OMKeyCreateRequest:
> {code:java}
>       // check Acl
>       checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
>           IAccessAuthorizer.ACLType.CREATE, OzoneObj.ResourceType.KEY);
>       acquireLock = omMetadataManager.getLock().acquireWriteLock(BUCKET_LOCK,
>           volumeName, bucketName);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org