You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/01/09 03:06:22 UTC
Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 8196fe2
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 5d80dce
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 2da19bc
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review67396
-----------------------------------------------------------
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
<https://reviews.apache.org/r/29749/#comment111414>
How about "return new MConnector(name, className, version, getLinkConfig(), from ? getFromConfig() : null, to ? getToConfig() : null);"
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
<https://reviews.apache.org/r/29749/#comment111415>
How about defining the strings like "Link-A", "Link-B" to const strings?
LGTM. two little comments.
- richard zhou
On Jan. 9, 2015, 6:13 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 6:13 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review67614
-----------------------------------------------------------
Nice, thank you for the patch Abe.
Since the tests are requiring external resources, I think that they are more integration tests then a unit tests and hence I'm wondering if it would make sense to put them into "integration" folder and execute them only as part of integration-test maven phase as we are doing in the "test" module?
Here is the associated surefire configuration:
https://github.com/apache/sqoop/blob/sqoop2/test/pom.xml#L148
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
<https://reviews.apache.org/r/29749/#comment111678>
I'm wondering why this change, what is different in calling fail() and throwing AssertionError?
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
<https://reviews.apache.org/r/29749/#comment111677>
We should call provider.escapeTableName(table)
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment111679>
Could you please add finally clause and properly close the ResultSet and PreparedStatement?
Jarcec
- Jarek Cecho
On Jan. 9, 2015, 6:13 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 6:13 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68254
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On Jan. 14, 2015, 1:38 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 1:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, line 145
> > <https://reviews.apache.org/r/29749/diff/8/?file=842750#file842750line145>
> >
> > Shouldn't we use the newly introduced method "escapeSchemaName()" here?
>
> Abraham Elmahrek wrote:
> Not sure actually. If we escape as a schema name and it doesn't have the same escape semantics, will it still work in DML statements?
>
> Jarek Cecho wrote:
> It's the same object type (=schema), so I would assume that it have to be escaped the same way regardless where it's used. For all the databases that I know the schema name is escaped the same way as table name, so I don't have an idea where to verify this theory.
Got it. Changing.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70624
-----------------------------------------------------------
On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > I'm wondering what is the reason behind removing the ProviderAssert class?
It became less useful since the metadata definition is a bit vague and a lot of it can be done in the DatabaseProvider.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70624
-----------------------------------------------------------
On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, line 145
> > <https://reviews.apache.org/r/29749/diff/8/?file=842750#file842750line145>
> >
> > Shouldn't we use the newly introduced method "escapeSchemaName()" here?
>
> Abraham Elmahrek wrote:
> Not sure actually. If we escape as a schema name and it doesn't have the same escape semantics, will it still work in DML statements?
It's the same object type (=schema), so I would assume that it have to be escaped the same way regardless where it's used. For all the databases that I know the schema name is escaped the same way as table name, so I don't have an idea where to verify this theory.
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java, line 31
> > <https://reviews.apache.org/r/29749/diff/8/?file=842762#file842762line31>
> >
> > Don't we have generic ProviderAsserts? Those method seems to be generic enough to be reused on other databases as well, right?
>
> Abraham Elmahrek wrote:
> Hmm not sure. The metadata definition for JDBC is a bit foreign to me. Would you mind if we kept it here for now and moved it out?
Sure, works for me.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70624
-----------------------------------------------------------
On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, line 145
> > <https://reviews.apache.org/r/29749/diff/8/?file=842750#file842750line145>
> >
> > Shouldn't we use the newly introduced method "escapeSchemaName()" here?
Not sure actually. If we escape as a schema name and it doesn't have the same escape semantics, will it still work in DML statements?
> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote:
> > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java, line 31
> > <https://reviews.apache.org/r/29749/diff/8/?file=842762#file842762line31>
> >
> > Don't we have generic ProviderAsserts? Those method seems to be generic enough to be reused on other databases as well, right?
Hmm not sure. The metadata definition for JDBC is a bit foreign to me. Would you mind if we kept it here for now and moved it out?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70624
-----------------------------------------------------------
On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70624
-----------------------------------------------------------
I'm wondering what is the reason behind removing the ProviderAssert class?
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment115877>
Since we do have a boolean method isSupportingScheme() that is suppose to return true/false whether schemes are support, would it make sense to make this method concrete and let the default implementation throw NotImplementedException?
I know that this is a test class, so API purity is probably not the first goal :)
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment115881>
Do you think that we can simplify that a bit? Perhaps:
sb.append(escape ? escapeTableName(tableName) : tableName)
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment115880>
Shouldn't we use the newly introduced method "escapeSchemaName()" here?
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment115882>
Shouldn't the default be:
stmt.setObject()
?
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment115883>
I think that we should keep the method rowCount(tableName) around as well in addition to the rowCount(schemaName, tableName).
common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java
<https://reviews.apache.org/r/29749/#comment115884>
MySQL doesn't have concept of schema, so this do seem a bit weird.
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
<https://reviews.apache.org/r/29749/#comment115885>
Nit: I would probably kept the original version with static imports of all the various contants, seems as better readable code, but I don't feel that strongly.
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java
<https://reviews.apache.org/r/29749/#comment115912>
Don't we have generic ProviderAsserts? Those method seems to be generic enough to be reused on other databases as well, right?
- Jarek Cecho
On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 12:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70921
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Feb. 3, 2015, 11:44 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 11:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 0b530b9
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 1d09b82
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 11:44 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 0b530b9
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 1d09b82
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 3, 2015, 4:21 a.m., Jarek Cecho wrote:
> > Sqoop2.ids, lines 1-15
> > <https://reviews.apache.org/r/29749/diff/10/?file=844867#file844867line1>
> >
> > Is this file intentionally included here?
Dropped in latest patch.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70703
-----------------------------------------------------------
On Feb. 3, 2015, 1:52 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> Sqoop2.ids PRE-CREATION
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review70703
-----------------------------------------------------------
Ship it!
One last comment:
Sqoop2.ids
<https://reviews.apache.org/r/29749/#comment116055>
Is this file intentionally included here?
Jarcec
- Jarek Cecho
On Feb. 3, 2015, 1:52 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> Sqoop2.ids PRE-CREATION
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
> common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
> common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
> common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 1:52 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
Sqoop2.ids PRE-CREATION
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 1:38 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
Sqoop2.ids PRE-CREATION
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 12:11 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 85af9a4
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 1124cd3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java f82abc7
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java b648870
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 7:07 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 98591a3
common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java 9814ac8
common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java d31bf28
common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java ed29a23
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java 9c56886
common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java f99d1ed
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java 98ba7a3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java 19fd6e7
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 941bb69
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 23, 2015, 1:58 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ae546f3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 11:32 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ae546f3
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java, line 67
> > <https://reviews.apache.org/r/29749/diff/4/?file=819457#file819457line67>
> >
> > I'm wondering what is the reason to drop the proper escaping?
>
> Abraham Elmahrek wrote:
> PostgreSQL escaping in a nut shell: http://stackoverflow.com/questions/6331504/omitting-the-double-quote-to-do-query-on-postgresql.
>
> Essentially, we create tables without any quoting so that the common repository handler will work. By adding quotes after the fact, it's difficult to get the correct query. It's much more reasonable to leave the quotes out.
I do see why we would want to stop escaping the table names because we are having inconsistencies in PostgreSQL repository. However I strongly believe that this is a bug in the Repository implementation and it should be fixed there rather then making the strict test provider more relaxed. Otherwise we will very sooon end up having all sort of random errors such as those that we've recently fixed in Sqoop 1 (SQOOP-1890). E.g I think that we should properly escape all table names rather then the other way around.
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, lines 253-255
> > <https://reviews.apache.org/r/29749/diff/4/?file=819456#file819456line253>
> >
> > We are not closing the PreparedStatement.
>
> Abraham Elmahrek wrote:
> closeResultSetWithStatement -> rs.getStatement().close()
Of course, got it :)
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------
On Jan. 16, 2015, 11:32 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 11:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ae546f3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java, line 67
> > <https://reviews.apache.org/r/29749/diff/4/?file=819457#file819457line67>
> >
> > I'm wondering what is the reason to drop the proper escaping?
>
> Abraham Elmahrek wrote:
> PostgreSQL escaping in a nut shell: http://stackoverflow.com/questions/6331504/omitting-the-double-quote-to-do-query-on-postgresql.
>
> Essentially, we create tables without any quoting so that the common repository handler will work. By adding quotes after the fact, it's difficult to get the correct query. It's much more reasonable to leave the quotes out.
>
> Jarek Cecho wrote:
> I do see why we would want to stop escaping the table names because we are having inconsistencies in PostgreSQL repository. However I strongly believe that this is a bug in the Repository implementation and it should be fixed there rather then making the strict test provider more relaxed. Otherwise we will very sooon end up having all sort of random errors such as those that we've recently fixed in Sqoop 1 (SQOOP-1890). E.g I think that we should properly escape all table names rather then the other way around.
>
> Abraham Elmahrek wrote:
> Let's fix in a separate bug? This requires significant changes that's far outside the scope of this jira.
I do understand that doing this the right way might require significant changes to PostgreSQL repository, but sadly I'm not fine with removing the proper escaping in generic JDBC provider. That is a generic test class that can be used outside of PostgreSQL repository and hence we should not introduce bugs into it just because PostgreSQL repository is buggy.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------
On Jan. 16, 2015, 11:32 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 11:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ae546f3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, lines 253-255
> > <https://reviews.apache.org/r/29749/diff/4/?file=819456#file819456line253>
> >
> > We are not closing the PreparedStatement.
closeResultSetWithStatement -> rs.getStatement().close()
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java, line 67
> > <https://reviews.apache.org/r/29749/diff/4/?file=819457#file819457line67>
> >
> > I'm wondering what is the reason to drop the proper escaping?
PostgreSQL escaping in a nut shell: http://stackoverflow.com/questions/6331504/omitting-the-double-quote-to-do-query-on-postgresql.
Essentially, we create tables without any quoting so that the common repository handler will work. By adding quotes after the fact, it's difficult to get the correct query. It's much more reasonable to leave the quotes out.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------
On Jan. 13, 2015, 5:38 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 5:38 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Jan. 15, 2015, 3:53 p.m., Jarek Cecho wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java, line 67
> > <https://reviews.apache.org/r/29749/diff/4/?file=819457#file819457line67>
> >
> > I'm wondering what is the reason to drop the proper escaping?
>
> Abraham Elmahrek wrote:
> PostgreSQL escaping in a nut shell: http://stackoverflow.com/questions/6331504/omitting-the-double-quote-to-do-query-on-postgresql.
>
> Essentially, we create tables without any quoting so that the common repository handler will work. By adding quotes after the fact, it's difficult to get the correct query. It's much more reasonable to leave the quotes out.
>
> Jarek Cecho wrote:
> I do see why we would want to stop escaping the table names because we are having inconsistencies in PostgreSQL repository. However I strongly believe that this is a bug in the Repository implementation and it should be fixed there rather then making the strict test provider more relaxed. Otherwise we will very sooon end up having all sort of random errors such as those that we've recently fixed in Sqoop 1 (SQOOP-1890). E.g I think that we should properly escape all table names rather then the other way around.
Let's fix in a separate bug? This requires significant changes that's far outside the scope of this jira.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------
On Jan. 16, 2015, 11:32 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 11:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ae546f3
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review68259
-----------------------------------------------------------
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
<https://reviews.apache.org/r/29749/#comment112427>
We are not closing the PreparedStatement.
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java
<https://reviews.apache.org/r/29749/#comment112428>
I'm wondering what is the reason to drop the proper escaping?
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java
<https://reviews.apache.org/r/29749/#comment112429>
PostgreSQL repository version 1 will be in 1.99.5. The version 1.99.4 has been already released and PostgreSQL repo hasn't been there :)
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java
<https://reviews.apache.org/r/29749/#comment112430>
I'm not sure why did we moved the main implementation into package "integration"? I though that this package "integration" is for integration tests only (e.g. not for "real" code).
- Jarek Cecho
On Jan. 13, 2015, 5:38 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 5:38 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 5:38 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/#review67849
-----------------------------------------------------------
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
<https://reviews.apache.org/r/29749/#comment111942>
Need a `(alwaysRun = true)`?
- Qian Xu
On Jan. 13, 2015, 2:50 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29749/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 2:50 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1591
> https://issues.apache.org/jira/browse/SQOOP-1591
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Wed Jan 7 20:44:44 2015 -0800
>
> SQOOP-1591: Sqoop2: PostgreSQL integration tests
>
> :100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
> :100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
> :100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
> :000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
> :000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
> :000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
> :000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
> :100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
> :000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
> common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
> repository/repository-postgresql/pom.xml 0ee9081
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
> repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
>
> Diff: https://reviews.apache.org/r/29749/diff/
>
>
> Testing
> -------
>
> mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 6:50 a.m.)
Review request for Sqoop.
Changes
-------
Moved all postgresql repostory tests under the package org.apache.sqoop.integration.repository.postgresql and made changes requests from Jarcec and Richard.
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java d46e01d
repository/repository-postgresql/pom.xml 0ee9081
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoConstants.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepoError.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlRepositoryHandler.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaConstants.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaCreateQuery.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlSchemaQuery.java PRE-CREATION
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java bdefd4c
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java 19ee505
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 4013d22
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 39abb2d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java a6319ac
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java f393521
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek
Re: Review Request 29749: SQOOP-1591: Sqoop2: PostgreSQL integration
tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29749/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 6:13 a.m.)
Review request for Sqoop.
Changes
-------
Rebased
Bugs: SQOOP-1591
https://issues.apache.org/jira/browse/SQOOP-1591
Repository: sqoop-sqoop2
Description
-------
commit 560387f1d3e6869ada914fa6ae5ada7d8e210721
Author: Abraham Elmahrek <ab...@apache.org>
Date: Wed Jan 7 20:44:44 2015 -0800
SQOOP-1591: Sqoop2: PostgreSQL integration tests
:100644 100644 8196fe2... cb987f6... M common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java
:100644 100644 82289e8... 3a6205e... M common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
:100644 100644 5d80dce... 7248d7c... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... 85f895d... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 6022bb3... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java
:000000 100644 0000000... 1dfacb5... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java
:000000 100644 0000000... 54c598e... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java
:100644 100644 2da19bc... 4735240... M repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
:000000 100644 0000000... 9db7940... A repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java fb4e7af
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 82289e8
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java ea199d4
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java PRE-CREATION
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java 6075de4
repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java PRE-CREATION
Diff: https://reviews.apache.org/r/29749/diff/
Testing
-------
mvn clean test -pl repository/repository-postgresql -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test -Dsqoop.provider.postgresql.username=test -Dsqoop.provider.postgresql.password=test
Thanks,
Abraham Elmahrek