You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/09/20 17:07:59 UTC
[commons-statistics] 11/13: Update test to use the protected
methods to verify expected values
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit b51024f31de2b6b1ba621b3a39e16a62fac80d29
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Sep 20 16:50:02 2021 +0100
Update test to use the protected methods to verify expected values
---
.../distribution/GeometricDistributionTest.java | 34 ++++++++++++----------
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
index 2c1f573..d4f1b39 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
@@ -160,22 +160,24 @@ class GeometricDistributionTest extends DiscreteDistributionAbstractTest {
Assertions.assertEquals(1.0, dist.getProbabilityOfSuccess());
Assertions.assertEquals(0.0, dist.getMean());
Assertions.assertEquals(0.0, dist.getVariance());
- // XXX: Fails (returns NaN)
- Assertions.assertEquals(1.0, dist.probability(0));
- Assertions.assertEquals(0.0, dist.probability(1));
- Assertions.assertEquals(0.0, dist.probability(2));
- // XXX: Fails (returns NaN)
- Assertions.assertEquals(0.0, dist.logProbability(0));
- Assertions.assertEquals(Double.NEGATIVE_INFINITY, dist.logProbability(1));
- Assertions.assertEquals(Double.NEGATIVE_INFINITY, dist.logProbability(2));
- Assertions.assertEquals(1.0, dist.cumulativeProbability(0));
- Assertions.assertEquals(1.0, dist.cumulativeProbability(1));
- Assertions.assertEquals(0.0, dist.survivalProbability(0));
- Assertions.assertEquals(0.0, dist.survivalProbability(1));
- Assertions.assertEquals(0, dist.inverseCumulativeProbability(0.0));
- Assertions.assertEquals(0, dist.inverseCumulativeProbability(0.5));
- // XXX: Fails (returns Integer.MAX_VALUE)
- Assertions.assertEquals(0, dist.inverseCumulativeProbability(1.0));
+
+ setDistribution(dist);
+ setProbabilityTestPoints(new int[] {0, 1, 2});
+ setProbabilityTestValues(new double[] {1.0, 0.0, 0.0});
+ setCumulativeTestPoints(new int[] {0, 1, 2});
+ setCumulativeTestValues(new double[] {1.0, 1.0, 1.0});
+ setInverseCumulativeTestPoints(new double[] {0, 0.5, 1.0});
+ setInverseCumulativeTestValues(new int[] {0, 0, 0});
+ // XXX: Fails (pmf(x=0) returns NaN)
+ verifyProbabilities();
+ // XXX: Fails (logpmf(x=0) returns NaN)
+ verifyLogProbabilities();
+ verifyCumulativeProbabilities();
+ verifySurvivalProbability();
+ verifySurvivalAndCumulativeProbabilityComplement();
+ // XXX: Fails (icdf(p=1) returns Integer.MAX_VALUE)
+ verifyInverseCumulativeProbabilities();
+
Assertions.assertEquals(0, dist.getSupportLowerBound());
// XXX: Fails (returns Integer.MAX_VALUE)
Assertions.assertEquals(0, dist.getSupportUpperBound());