You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by piyush mukati <pi...@gmail.com> on 2015/12/16 07:12:08 UTC
Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-896
https://issues.apache.org/jira/browse/LENS-896
Repository: lens
Description
-------
fix for setting base url. Inside method JDBCUtils.parseUrl
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
Diff: https://reviews.apache.org/r/41437/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
[INFO] Lens ............................................... SUCCESS [ 6.401 s]
[INFO] Lens API ........................................... SUCCESS [ 24.920 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
[INFO] Lens Cube .......................................... SUCCESS [09:05 min]
[INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
[INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
[INFO] Lens Server ........................................ SUCCESS [15:12 min]
[INFO] Lens client ........................................ SUCCESS [ 40.419 s]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
[INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
[INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:12 min
[INFO] Finished at: 2015-12-15T17:28:09+05:30
[INFO] Final Memory: 130M/844M
Thanks,
piyush mukati
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, line 54
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line54>
> >
> > Why is this removed? Shouldn't default url be set if no uri is passed ?
setBaseUrl is derived from hostname and port.
we can have default hostname and port if not passed in connection url.
- piyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
On Dec. 16, 2015, 6:12 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 6:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, lines 81-83
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line81>
> >
> > Can we put the commented asserts back?
>
> piyush mukati wrote:
> For this test, we have to uncomment below code in JDBCUtils.java
> / * if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } if (jdbcUri.getPort() > 0) { * params.setPort(jdbcUri.getPort()); } /
>
> I was not sure why it was commented erliar, so i didnt change.
>
> Amareshwari Sriramadasu wrote:
> If you see there is no issue with the code, go ahead and uncomment.
>
> piyush mukati wrote:
> Above portion was commented because now LensClientConfig does not have host or port in configuration. it has only SERVER_BASE_URL. host and port are derived from base url.
Piyush, thanks for spending time figuring out. Shall we remove the commented code?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
On Dec. 18, 2015, 6:13 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, lines 81-83
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line81>
> >
> > Can we put the commented asserts back?
>
> piyush mukati wrote:
> For this test, we have to uncomment below code in JDBCUtils.java
> / * if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } if (jdbcUri.getPort() > 0) { * params.setPort(jdbcUri.getPort()); } /
>
> I was not sure why it was commented erliar, so i didnt change.
>
> Amareshwari Sriramadasu wrote:
> If you see there is no issue with the code, go ahead and uncomment.
Above portion was commented because now LensClientConfig does not have host or port in configuration. it has only SERVER_BASE_URL. host and port are derived from base url.
- piyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
On Dec. 18, 2015, 6:13 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, lines 81-83
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line81>
> >
> > Can we put the commented asserts back?
For this test, we have to uncomment below code in JDBCUtils.java
/ * if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } if (jdbcUri.getPort() > 0) { * params.setPort(jdbcUri.getPort()); } /
I was not sure why it was commented erliar, so i didnt change.
- piyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
On Dec. 16, 2015, 6:12 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 6:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, lines 81-83
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line81>
> >
> > Can we put the commented asserts back?
>
> piyush mukati wrote:
> For this test, we have to uncomment below code in JDBCUtils.java
> / * if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } if (jdbcUri.getPort() > 0) { * params.setPort(jdbcUri.getPort()); } /
>
> I was not sure why it was commented erliar, so i didnt change.
If you see there is no issue with the code, go ahead and uncomment.
> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, line 54
> > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line54>
> >
> > Why is this removed? Shouldn't default url be set if no uri is passed ?
>
> piyush mukati wrote:
> setBaseUrl is derived from hostname and port.
> we can have default hostname and port if not passed in connection url.
Would be good to have defaults as well.
Also, can you check documentation at http://lens.apache.org/user/jdbc-client.html is all correct and update if anything is required.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
On Dec. 17, 2015, 10:41 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 10:41 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110628
-----------------------------------------------------------
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java
<https://reviews.apache.org/r/41437/#comment170607>
Why is this removed? Shouldn't default url be set if no uri is passed ?
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java (lines 79 - 81)
<https://reviews.apache.org/r/41437/#comment170605>
Can we put the commented asserts back?
- Amareshwari Sriramadasu
On Dec. 16, 2015, 6:12 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 6:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110653
-----------------------------------------------------------
Ship it!
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java (line 82)
<https://reviews.apache.org/r/41437/#comment170687>
The correct signature is
Assert.assertEquals(actual, expected, messgae)
Please swap the arguments.
- Rajat Khandelwal
On Dec. 16, 2015, 11:42 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 11:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review110666
-----------------------------------------------------------
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java
<https://reviews.apache.org/r/41437/#comment170711>
setBaseUrl is derived from hostname and port.
we can have default hostname and port if not passed in connection url.
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java (lines 79 - 81)
<https://reviews.apache.org/r/41437/#comment170709>
For this test, we have to uncomment below code in JDBCUtils.java
/*
* if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } if (jdbcUri.getPort() > 0) {
* params.setPort(jdbcUri.getPort()); }
*/
I was not sure why it was commented erliar.
- piyush mukati
On Dec. 16, 2015, 6:12 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 6:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/#review111139
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 18, 2015, 6:52 a.m., piyush mukati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41437/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:52 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-896
> https://issues.apache.org/jira/browse/LENS-896
>
>
> Repository: lens
>
>
> Description
> -------
>
> fix for setting base url. Inside method JDBCUtils.parseUrl
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
> lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
>
> Diff: https://reviews.apache.org/r/41437/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
> [INFO] Lens ............................................... SUCCESS [ 6.401 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.920 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:05 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
> [INFO] Lens Server ........................................ SUCCESS [15:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 40.419 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
> [INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
> [INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:12 min
> [INFO] Finished at: 2015-12-15T17:28:09+05:30
> [INFO] Final Memory: 130M/844M
>
>
> Thanks,
>
> piyush mukati
>
>
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 6:52 a.m.)
Review request for lens.
Bugs: LENS-896
https://issues.apache.org/jira/browse/LENS-896
Repository: lens
Description
-------
fix for setting base url. Inside method JDBCUtils.parseUrl
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
Diff: https://reviews.apache.org/r/41437/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
[INFO] Lens ............................................... SUCCESS [ 6.401 s]
[INFO] Lens API ........................................... SUCCESS [ 24.920 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
[INFO] Lens Cube .......................................... SUCCESS [09:05 min]
[INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
[INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
[INFO] Lens Server ........................................ SUCCESS [15:12 min]
[INFO] Lens client ........................................ SUCCESS [ 40.419 s]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
[INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
[INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:12 min
[INFO] Finished at: 2015-12-15T17:28:09+05:30
[INFO] Final Memory: 130M/844M
Thanks,
piyush mukati
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 6:13 a.m.)
Review request for lens.
Changes
-------
default url be set if no uri is passed
Bugs: LENS-896
https://issues.apache.org/jira/browse/LENS-896
Repository: lens
Description
-------
fix for setting base url. Inside method JDBCUtils.parseUrl
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
Diff: https://reviews.apache.org/r/41437/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
[INFO] Lens ............................................... SUCCESS [ 6.401 s]
[INFO] Lens API ........................................... SUCCESS [ 24.920 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
[INFO] Lens Cube .......................................... SUCCESS [09:05 min]
[INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
[INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
[INFO] Lens Server ........................................ SUCCESS [15:12 min]
[INFO] Lens client ........................................ SUCCESS [ 40.419 s]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
[INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
[INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:12 min
[INFO] Finished at: 2015-12-15T17:28:09+05:30
[INFO] Final Memory: 130M/844M
Thanks,
piyush mukati
Re: Review Request 41437: fix for setting base url. Inside method
JDBCUtils.parseUrl
Posted by piyush mukati <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41437/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 10:41 a.m.)
Review request for lens.
Changes
-------
corrected parameters in Assert#assertEquals
Bugs: LENS-896
https://issues.apache.org/jira/browse/LENS-896
Repository: lens
Description
-------
fix for setting base url. Inside method JDBCUtils.parseUrl
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 34448d3
lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java 3c97878
Diff: https://reviews.apache.org/r/41437/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 s]
[INFO] Lens ............................................... SUCCESS [ 6.401 s]
[INFO] Lens API ........................................... SUCCESS [ 24.920 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 s]
[INFO] Lens Cube .......................................... SUCCESS [09:05 min]
[INFO] Lens DB storage .................................... SUCCESS [ 15.916 s]
[INFO] Lens Query Library ................................. SUCCESS [ 12.904 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 s]
[INFO] Lens Server ........................................ SUCCESS [15:12 min]
[INFO] Lens client ........................................ SUCCESS [ 40.419 s]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.399 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.348 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 s]
[INFO] Lens Regression .................................... SUCCESS [ 19.590 s]
[INFO] Lens UI ............................................ SUCCESS [ 5.102 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:12 min
[INFO] Finished at: 2015-12-15T17:28:09+05:30
[INFO] Final Memory: 130M/844M
Thanks,
piyush mukati