You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/10/04 20:40:49 UTC
Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget
menu)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 6:40 p.m.)
Review request for rave.
Changes
-------
I'm afraid those both are relics I failed to remove before creating the patch. Attaching update patch file.
Description
-------
Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).
https://issues.apache.org/jira/browse/RAVE-532
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1394186
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394186
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1394186
Diff: https://reviews.apache.org/r/6286/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget
menu)
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 6:43 p.m.)
Review request for rave.
Description
-------
Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).
https://issues.apache.org/jira/browse/RAVE-532
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1394186
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394186
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1394186
Diff: https://reviews.apache.org/r/6286/diff/
Testing
-------
Thanks,
Kristen Legacy