You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Fasih (JIRA)" <ji...@apache.org> on 2011/03/22 16:42:05 UTC

[jira] [Resolved] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall

     [ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fasih resolved THRIFT-1106.
---------------------------

       Resolution: Fixed
    Fix Version/s: 0.6

Attached patch fixes the problem

> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1106
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1106
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>            Reporter: Fasih
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: create-virtual-dtor.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira