You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/04/02 19:32:01 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5827: Implement LogicalPlan support for transactions

alamb commented on code in PR #5827:
URL: https://github.com/apache/arrow-datafusion/pull/5827#discussion_r1155363480


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1057,6 +1069,20 @@ impl LogicalPlan {
                     }) => {
                         write!(f, "DropTable: {name:?} if not exist:={if_exists}")
                     }
+                    LogicalPlan::TransactionStart(TransactionStartNode {

Review Comment:
   The other variants seem to use the name name for the variant and the structure they contain. I wonder if we should call this `TransactionStart` rather than TransactionStartNode` 🤔 
   
   ```suggestion
                       LogicalPlan::TransactionStart(TransactionStart {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org