You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/07/08 04:45:38 UTC

Review Request 60724: Fixed initialization of `LIBPROCESS_IP6`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Benjamin Hindman.


Bugs: MESOS-7772
    https://issues.apache.org/jira/browse/MESOS-7772


Repository: mesos


Description
-------

Fixed initialization of `LIBPROCESS_IP6`.


Diffs
-----

  src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 


Diff: https://reviews.apache.org/r/60724/diff/1/


Testing
-------

make check


Thanks,

Avinash sridharan


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6`.

Posted by Avinash sridharan <av...@mesosphere.io>.

> On July 8, 2017, 10:23 a.m., Benjamin Bannier wrote:
> > Since this wasn't caught by `make check` previously, do we have manual steps we could perform to verify that the `--ip6` flag of libprocess works?

Valid point. Have added the output from the manual testing when the `--ip6` flag is set on the agent. The `task` output in agent and master state clearly shows that the IPv6 set by the operator is set for the container running on the host network.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/#review179980
-----------------------------------------------------------


On July 8, 2017, 4:45 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60724/
> -----------------------------------------------------------
> 
> (Updated July 8, 2017, 4:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-7772
>     https://issues.apache.org/jira/browse/MESOS-7772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed initialization of `LIBPROCESS_IP6`.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 
> 
> 
> Diff: https://reviews.apache.org/r/60724/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6`.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/#review179980
-----------------------------------------------------------



Since this wasn't caught by `make check` previously, do we have manual steps we could perform to verify that the `--ip6` flag of libprocess works?

- Benjamin Bannier


On July 8, 2017, 6:45 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60724/
> -----------------------------------------------------------
> 
> (Updated July 8, 2017, 6:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-7772
>     https://issues.apache.org/jira/browse/MESOS-7772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed initialization of `LIBPROCESS_IP6`.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 
> 
> 
> Diff: https://reviews.apache.org/r/60724/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/#review180066
-----------------------------------------------------------


Ship it!




- Benjamin Hindman


On July 9, 2017, 8:23 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60724/
> -----------------------------------------------------------
> 
> (Updated July 9, 2017, 8:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-7772
>     https://issues.apache.org/jira/browse/MESOS-7772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed initialization of `LIBPROCESS_IP6`.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 
> 
> 
> Diff: https://reviews.apache.org/r/60724/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> MANUAL TESTING
> ================
> ~/dev/mesosphere/mesos$ sudo ./build/bin/mesos-agent.sh --ip=10.0.2.15 --ip6=1::1 --master=10.0.2.15:5050 --work_dir=/tmp/mesos --containerizers=mesos,docker
> 
> ~/dev/mesosphere/mesos$ sudo ./build/src/mesos-execute --master=10.0.2.15:5050 --task=file:///home/vagrant/dev/mesos_apps/docker_host.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0709 20:01:42.282433  4953 scheduler.cpp:169]
> **************************************************
> Scheduler driver bound to loopback interface! Cannot communicate with remote master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a routable IP address.
> **************************************************
> I0709 20:01:42.282627  4953 scheduler.cpp:184] Version: 1.4.0
> I0709 20:01:42.300417  4972 scheduler.cpp:470] New master detected at master@10.0.2.15:5050
> Subscribed with ID 70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002
> Submitted task 'test' to agent '70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0'
> Received status update TASK_RUNNING for task 'test_docker'
>   source: SOURCE_EXECUTOR
> 
> vagrant@centos7:~$ curl http://10.0.2.15:5051/state | jq
> "frameworks": [
>     {
>       "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>       "name": "mesos-execute instance",
>       "user": "root",
>       "failover_timeout": 0,
>       "checkpoint": false,
>       "hostname": "",
>       "role": "*",
>       "executors": [
>         {
>           "id": "test_docker",
>           "name": "Command Executor (Task: test_docker) (Command: NO EXECUTABLE)",
>           "source": "test_docker",
>           "container": "8a51cdfb-2039-407a-942e-52bb66bd1a4c",
>           "directory": "/tmp/mesos/slaves/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0/frameworks/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001/executors/test_docker/runs/8a51cdfb-2039-407a-942e-52bb66bd1a4c",
>           "resources": {
>             "disk": 0,
>             "mem": 64,
>             "gpus": 0,
>             "cpus": 0.2
>           },
>           "role": "*",
>           "tasks": [
>             {
>               "id": "test_docker",
>               "name": "test",
>               "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>               "executor_id": "",
>               "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
>               "state": "TASK_RUNNING",
>               "resources": {
>                 "disk": 0,
>                 "mem": 32,
>                 "gpus": 0,
>                 "cpus": 0.1
>               },
>               "role": "*",
>               "statuses": [
>                 {
>                   "state": "TASK_RUNNING",
>                   "timestamp": 1499630245.73584,
>                   "container_status": {
>                     "container_id": {
>                       "value": "8a51cdfb-2039-407a-942e-52bb66bd1a4c"
>                     },
>                     "network_infos": [
>                       {
>                         "ip_addresses": [
>                           {
>                             "protocol": "IPv4",
>                             "ip_address": "10.0.2.15"
>                           },
>                           {
>                             "protocol": "IPv6",
>                             "ip_address": "1::1"   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<IPv6 address specified.
>                           }
>                         ]
>                       }
>                     ]
>                   }
>                 }
>               ],
>               "container": {
>                 "type": "DOCKER",
>                 "docker": {
>                   "image": "nginx",
>                   "network": "HOST",
>                   "privileged": false
>                 }
>               }
>             }
>           ],
>           "queued_tasks": [],
>           "completed_tasks": []
>         }
>       ],
>       "completed_executors": []
>     }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> curl http://10.0.2.15:5050/state | jq
>     {
>       "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>       "name": "mesos-execute instance",
>       "used_resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "offered_resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "capabilities": [
>         "RESERVATION_REFINEMENT",
>         "TASK_KILLING_STATE",
>         "PARTITION_AWARE"
>       ],
>       "hostname": "",
>       "webui_url": "",
>       "active": false,
>       "connected": false,
>       "recovered": false,
>       "user": "root",
>       "failover_timeout": 0,
>       "checkpoint": false,
>       "registered_time": 1499630244.83417,
>       "unregistered_time": 1499630426.87537,
>       "resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "role": "*",
>       "tasks": [],
>       "unreachable_tasks": [],
>       "completed_tasks": [
>         {
>           "id": "test_docker",
>           "name": "test",
>           "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>           "executor_id": "","tasks": [
>         {
>           "id": "test_docker",
>           "name": "test",
>           "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002",
>           "executor_id": "",
>           "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
>           "state": "TASK_RUNNING",
>           "resources": {
>             "disk": 0,
>             "mem": 32,
>             "gpus": 0,
>             "cpus": 0.1
>           },
>           "role": "*",
>           "statuses": [
>             {
>               "state": "TASK_RUNNING",
>               "timestamp": 1499630503.20322,
>               "container_status": {
>                 "container_id": {
>                   "value": "29e6f09b-53f5-436c-91ad-f83299ef849a"
>                 },
>                 "network_infos": [
>                   {
>                     "ip_addresses": [
>                       {
>                         "protocol": "IPv4",
>                         "ip_address": "10.0.2.15"
>                       },
>                       {
>                         "protocol": "IPv6",
>                         "ip_address": "1::1"                <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<Master state reflecting IPv6 as well. 
>                       }
>                     ]
>                   }
>                 ]
>               }
>             }
>           ],
>           "container": {
>             "type": "DOCKER",
>             "docker": {
>               "image": "nginx",
>               "network": "HOST",
>               "privileged": false
>             }
>           }
>         }
>       ],
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/#review180050
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On July 9, 2017, 10:23 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60724/
> -----------------------------------------------------------
> 
> (Updated July 9, 2017, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Hindman.
> 
> 
> Bugs: MESOS-7772
>     https://issues.apache.org/jira/browse/MESOS-7772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed initialization of `LIBPROCESS_IP6`.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 
> 
> 
> Diff: https://reviews.apache.org/r/60724/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> MANUAL TESTING
> ================
> ~/dev/mesosphere/mesos$ sudo ./build/bin/mesos-agent.sh --ip=10.0.2.15 --ip6=1::1 --master=10.0.2.15:5050 --work_dir=/tmp/mesos --containerizers=mesos,docker
> 
> ~/dev/mesosphere/mesos$ sudo ./build/src/mesos-execute --master=10.0.2.15:5050 --task=file:///home/vagrant/dev/mesos_apps/docker_host.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0709 20:01:42.282433  4953 scheduler.cpp:169]
> **************************************************
> Scheduler driver bound to loopback interface! Cannot communicate with remote master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a routable IP address.
> **************************************************
> I0709 20:01:42.282627  4953 scheduler.cpp:184] Version: 1.4.0
> I0709 20:01:42.300417  4972 scheduler.cpp:470] New master detected at master@10.0.2.15:5050
> Subscribed with ID 70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002
> Submitted task 'test' to agent '70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0'
> Received status update TASK_RUNNING for task 'test_docker'
>   source: SOURCE_EXECUTOR
> 
> vagrant@centos7:~$ curl http://10.0.2.15:5051/state | jq
> "frameworks": [
>     {
>       "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>       "name": "mesos-execute instance",
>       "user": "root",
>       "failover_timeout": 0,
>       "checkpoint": false,
>       "hostname": "",
>       "role": "*",
>       "executors": [
>         {
>           "id": "test_docker",
>           "name": "Command Executor (Task: test_docker) (Command: NO EXECUTABLE)",
>           "source": "test_docker",
>           "container": "8a51cdfb-2039-407a-942e-52bb66bd1a4c",
>           "directory": "/tmp/mesos/slaves/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0/frameworks/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001/executors/test_docker/runs/8a51cdfb-2039-407a-942e-52bb66bd1a4c",
>           "resources": {
>             "disk": 0,
>             "mem": 64,
>             "gpus": 0,
>             "cpus": 0.2
>           },
>           "role": "*",
>           "tasks": [
>             {
>               "id": "test_docker",
>               "name": "test",
>               "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>               "executor_id": "",
>               "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
>               "state": "TASK_RUNNING",
>               "resources": {
>                 "disk": 0,
>                 "mem": 32,
>                 "gpus": 0,
>                 "cpus": 0.1
>               },
>               "role": "*",
>               "statuses": [
>                 {
>                   "state": "TASK_RUNNING",
>                   "timestamp": 1499630245.73584,
>                   "container_status": {
>                     "container_id": {
>                       "value": "8a51cdfb-2039-407a-942e-52bb66bd1a4c"
>                     },
>                     "network_infos": [
>                       {
>                         "ip_addresses": [
>                           {
>                             "protocol": "IPv4",
>                             "ip_address": "10.0.2.15"
>                           },
>                           {
>                             "protocol": "IPv6",
>                             "ip_address": "1::1"   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<IPv6 address specified.
>                           }
>                         ]
>                       }
>                     ]
>                   }
>                 }
>               ],
>               "container": {
>                 "type": "DOCKER",
>                 "docker": {
>                   "image": "nginx",
>                   "network": "HOST",
>                   "privileged": false
>                 }
>               }
>             }
>           ],
>           "queued_tasks": [],
>           "completed_tasks": []
>         }
>       ],
>       "completed_executors": []
>     }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> curl http://10.0.2.15:5050/state | jq
>     {
>       "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>       "name": "mesos-execute instance",
>       "used_resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "offered_resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "capabilities": [
>         "RESERVATION_REFINEMENT",
>         "TASK_KILLING_STATE",
>         "PARTITION_AWARE"
>       ],
>       "hostname": "",
>       "webui_url": "",
>       "active": false,
>       "connected": false,
>       "recovered": false,
>       "user": "root",
>       "failover_timeout": 0,
>       "checkpoint": false,
>       "registered_time": 1499630244.83417,
>       "unregistered_time": 1499630426.87537,
>       "resources": {
>         "disk": 0,
>         "mem": 0,
>         "gpus": 0,
>         "cpus": 0
>       },
>       "role": "*",
>       "tasks": [],
>       "unreachable_tasks": [],
>       "completed_tasks": [
>         {
>           "id": "test_docker",
>           "name": "test",
>           "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
>           "executor_id": "","tasks": [
>         {
>           "id": "test_docker",
>           "name": "test",
>           "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002",
>           "executor_id": "",
>           "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
>           "state": "TASK_RUNNING",
>           "resources": {
>             "disk": 0,
>             "mem": 32,
>             "gpus": 0,
>             "cpus": 0.1
>           },
>           "role": "*",
>           "statuses": [
>             {
>               "state": "TASK_RUNNING",
>               "timestamp": 1499630503.20322,
>               "container_status": {
>                 "container_id": {
>                   "value": "29e6f09b-53f5-436c-91ad-f83299ef849a"
>                 },
>                 "network_infos": [
>                   {
>                     "ip_addresses": [
>                       {
>                         "protocol": "IPv4",
>                         "ip_address": "10.0.2.15"
>                       },
>                       {
>                         "protocol": "IPv6",
>                         "ip_address": "1::1"                <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<Master state reflecting IPv6 as well. 
>                       }
>                     ]
>                   }
>                 ]
>               }
>             }
>           ],
>           "container": {
>             "type": "DOCKER",
>             "docker": {
>               "image": "nginx",
>               "network": "HOST",
>               "privileged": false
>             }
>           }
>         }
>       ],
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/
-----------------------------------------------------------

(Updated July 9, 2017, 8:23 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Hindman.


Changes
-------

Fixed the summary.


Summary (updated)
-----------------

Fixed initialization of `LIBPROCESS_IP6` on agent.


Bugs: MESOS-7772
    https://issues.apache.org/jira/browse/MESOS-7772


Repository: mesos


Description
-------

Fixed initialization of `LIBPROCESS_IP6`.


Diffs
-----

  src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 


Diff: https://reviews.apache.org/r/60724/diff/1/


Testing
-------

make check

MANUAL TESTING
================
~/dev/mesosphere/mesos$ sudo ./build/bin/mesos-agent.sh --ip=10.0.2.15 --ip6=1::1 --master=10.0.2.15:5050 --work_dir=/tmp/mesos --containerizers=mesos,docker

~/dev/mesosphere/mesos$ sudo ./build/src/mesos-execute --master=10.0.2.15:5050 --task=file:///home/vagrant/dev/mesos_apps/docker_host.json
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0709 20:01:42.282433  4953 scheduler.cpp:169]
**************************************************
Scheduler driver bound to loopback interface! Cannot communicate with remote master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a routable IP address.
**************************************************
I0709 20:01:42.282627  4953 scheduler.cpp:184] Version: 1.4.0
I0709 20:01:42.300417  4972 scheduler.cpp:470] New master detected at master@10.0.2.15:5050
Subscribed with ID 70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002
Submitted task 'test' to agent '70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0'
Received status update TASK_RUNNING for task 'test_docker'
  source: SOURCE_EXECUTOR

vagrant@centos7:~$ curl http://10.0.2.15:5051/state | jq
"frameworks": [
    {
      "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
      "name": "mesos-execute instance",
      "user": "root",
      "failover_timeout": 0,
      "checkpoint": false,
      "hostname": "",
      "role": "*",
      "executors": [
        {
          "id": "test_docker",
          "name": "Command Executor (Task: test_docker) (Command: NO EXECUTABLE)",
          "source": "test_docker",
          "container": "8a51cdfb-2039-407a-942e-52bb66bd1a4c",
          "directory": "/tmp/mesos/slaves/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0/frameworks/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001/executors/test_docker/runs/8a51cdfb-2039-407a-942e-52bb66bd1a4c",
          "resources": {
            "disk": 0,
            "mem": 64,
            "gpus": 0,
            "cpus": 0.2
          },
          "role": "*",
          "tasks": [
            {
              "id": "test_docker",
              "name": "test",
              "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
              "executor_id": "",
              "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
              "state": "TASK_RUNNING",
              "resources": {
                "disk": 0,
                "mem": 32,
                "gpus": 0,
                "cpus": 0.1
              },
              "role": "*",
              "statuses": [
                {
                  "state": "TASK_RUNNING",
                  "timestamp": 1499630245.73584,
                  "container_status": {
                    "container_id": {
                      "value": "8a51cdfb-2039-407a-942e-52bb66bd1a4c"
                    },
                    "network_infos": [
                      {
                        "ip_addresses": [
                          {
                            "protocol": "IPv4",
                            "ip_address": "10.0.2.15"
                          },
                          {
                            "protocol": "IPv6",
                            "ip_address": "1::1"   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<IPv6 address specified.
                          }
                        ]
                      }
                    ]
                  }
                }
              ],
              "container": {
                "type": "DOCKER",
                "docker": {
                  "image": "nginx",
                  "network": "HOST",
                  "privileged": false
                }
              }
            }
          ],
          "queued_tasks": [],
          "completed_tasks": []
        }
      ],
      "completed_executors": []
    }
  ],
  "completed_frameworks": []
}


curl http://10.0.2.15:5050/state | jq
    {
      "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
      "name": "mesos-execute instance",
      "used_resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "offered_resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "capabilities": [
        "RESERVATION_REFINEMENT",
        "TASK_KILLING_STATE",
        "PARTITION_AWARE"
      ],
      "hostname": "",
      "webui_url": "",
      "active": false,
      "connected": false,
      "recovered": false,
      "user": "root",
      "failover_timeout": 0,
      "checkpoint": false,
      "registered_time": 1499630244.83417,
      "unregistered_time": 1499630426.87537,
      "resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "role": "*",
      "tasks": [],
      "unreachable_tasks": [],
      "completed_tasks": [
        {
          "id": "test_docker",
          "name": "test",
          "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
          "executor_id": "","tasks": [
        {
          "id": "test_docker",
          "name": "test",
          "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002",
          "executor_id": "",
          "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
          "state": "TASK_RUNNING",
          "resources": {
            "disk": 0,
            "mem": 32,
            "gpus": 0,
            "cpus": 0.1
          },
          "role": "*",
          "statuses": [
            {
              "state": "TASK_RUNNING",
              "timestamp": 1499630503.20322,
              "container_status": {
                "container_id": {
                  "value": "29e6f09b-53f5-436c-91ad-f83299ef849a"
                },
                "network_infos": [
                  {
                    "ip_addresses": [
                      {
                        "protocol": "IPv4",
                        "ip_address": "10.0.2.15"
                      },
                      {
                        "protocol": "IPv6",
                        "ip_address": "1::1"                <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<Master state reflecting IPv6 as well. 
                      }
                    ]
                  }
                ]
              }
            }
          ],
          "container": {
            "type": "DOCKER",
            "docker": {
              "image": "nginx",
              "network": "HOST",
              "privileged": false
            }
          }
        }
      ],


Thanks,

Avinash sridharan


Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6`.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60724/
-----------------------------------------------------------

(Updated July 9, 2017, 8:23 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Hindman.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-7772
    https://issues.apache.org/jira/browse/MESOS-7772


Repository: mesos


Description
-------

Fixed initialization of `LIBPROCESS_IP6`.


Diffs
-----

  src/slave/main.cpp 358a4394d27d2d123c9cdc9ed3e5295ecbaf9130 


Diff: https://reviews.apache.org/r/60724/diff/1/


Testing (updated)
-------

make check

MANUAL TESTING
================
~/dev/mesosphere/mesos$ sudo ./build/bin/mesos-agent.sh --ip=10.0.2.15 --ip6=1::1 --master=10.0.2.15:5050 --work_dir=/tmp/mesos --containerizers=mesos,docker

~/dev/mesosphere/mesos$ sudo ./build/src/mesos-execute --master=10.0.2.15:5050 --task=file:///home/vagrant/dev/mesos_apps/docker_host.json
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0709 20:01:42.282433  4953 scheduler.cpp:169]
**************************************************
Scheduler driver bound to loopback interface! Cannot communicate with remote master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a routable IP address.
**************************************************
I0709 20:01:42.282627  4953 scheduler.cpp:184] Version: 1.4.0
I0709 20:01:42.300417  4972 scheduler.cpp:470] New master detected at master@10.0.2.15:5050
Subscribed with ID 70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002
Submitted task 'test' to agent '70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0'
Received status update TASK_RUNNING for task 'test_docker'
  source: SOURCE_EXECUTOR

vagrant@centos7:~$ curl http://10.0.2.15:5051/state | jq
"frameworks": [
    {
      "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
      "name": "mesos-execute instance",
      "user": "root",
      "failover_timeout": 0,
      "checkpoint": false,
      "hostname": "",
      "role": "*",
      "executors": [
        {
          "id": "test_docker",
          "name": "Command Executor (Task: test_docker) (Command: NO EXECUTABLE)",
          "source": "test_docker",
          "container": "8a51cdfb-2039-407a-942e-52bb66bd1a4c",
          "directory": "/tmp/mesos/slaves/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0/frameworks/70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001/executors/test_docker/runs/8a51cdfb-2039-407a-942e-52bb66bd1a4c",
          "resources": {
            "disk": 0,
            "mem": 64,
            "gpus": 0,
            "cpus": 0.2
          },
          "role": "*",
          "tasks": [
            {
              "id": "test_docker",
              "name": "test",
              "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
              "executor_id": "",
              "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
              "state": "TASK_RUNNING",
              "resources": {
                "disk": 0,
                "mem": 32,
                "gpus": 0,
                "cpus": 0.1
              },
              "role": "*",
              "statuses": [
                {
                  "state": "TASK_RUNNING",
                  "timestamp": 1499630245.73584,
                  "container_status": {
                    "container_id": {
                      "value": "8a51cdfb-2039-407a-942e-52bb66bd1a4c"
                    },
                    "network_infos": [
                      {
                        "ip_addresses": [
                          {
                            "protocol": "IPv4",
                            "ip_address": "10.0.2.15"
                          },
                          {
                            "protocol": "IPv6",
                            "ip_address": "1::1"   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<IPv6 address specified.
                          }
                        ]
                      }
                    ]
                  }
                }
              ],
              "container": {
                "type": "DOCKER",
                "docker": {
                  "image": "nginx",
                  "network": "HOST",
                  "privileged": false
                }
              }
            }
          ],
          "queued_tasks": [],
          "completed_tasks": []
        }
      ],
      "completed_executors": []
    }
  ],
  "completed_frameworks": []
}


curl http://10.0.2.15:5050/state | jq
    {
      "id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
      "name": "mesos-execute instance",
      "used_resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "offered_resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "capabilities": [
        "RESERVATION_REFINEMENT",
        "TASK_KILLING_STATE",
        "PARTITION_AWARE"
      ],
      "hostname": "",
      "webui_url": "",
      "active": false,
      "connected": false,
      "recovered": false,
      "user": "root",
      "failover_timeout": 0,
      "checkpoint": false,
      "registered_time": 1499630244.83417,
      "unregistered_time": 1499630426.87537,
      "resources": {
        "disk": 0,
        "mem": 0,
        "gpus": 0,
        "cpus": 0
      },
      "role": "*",
      "tasks": [],
      "unreachable_tasks": [],
      "completed_tasks": [
        {
          "id": "test_docker",
          "name": "test",
          "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0001",
          "executor_id": "","tasks": [
        {
          "id": "test_docker",
          "name": "test",
          "framework_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-0002",
          "executor_id": "",
          "slave_id": "70b8df2f-4b14-4597-a3c2-01f16ccd5b6f-S0",
          "state": "TASK_RUNNING",
          "resources": {
            "disk": 0,
            "mem": 32,
            "gpus": 0,
            "cpus": 0.1
          },
          "role": "*",
          "statuses": [
            {
              "state": "TASK_RUNNING",
              "timestamp": 1499630503.20322,
              "container_status": {
                "container_id": {
                  "value": "29e6f09b-53f5-436c-91ad-f83299ef849a"
                },
                "network_infos": [
                  {
                    "ip_addresses": [
                      {
                        "protocol": "IPv4",
                        "ip_address": "10.0.2.15"
                      },
                      {
                        "protocol": "IPv6",
                        "ip_address": "1::1"                <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<Master state reflecting IPv6 as well. 
                      }
                    ]
                  }
                ]
              }
            }
          ],
          "container": {
            "type": "DOCKER",
            "docker": {
              "image": "nginx",
              "network": "HOST",
              "privileged": false
            }
          }
        }
      ],


Thanks,

Avinash sridharan