You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Milosz Tylenda (JIRA)" <ji...@apache.org> on 2008/12/31 11:18:44 UTC

[jira] Created: (OPENJPA-847) Retrieving database generated keys gets never enabled

Retrieving database generated keys gets never enabled
-----------------------------------------------------

                 Key: OPENJPA-847
                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
             Project: OpenJPA
          Issue Type: Bug
          Components: jdbc
    Affects Versions: 2.0.0
            Reporter: Milosz Tylenda
            Priority: Minor


Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-847) Retrieving database generated keys gets never enabled

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714710#action_12714710 ] 

Milosz Tylenda commented on OPENJPA-847:
----------------------------------------

Change applied to trunk.

> Retrieving database generated keys gets never enabled
> -----------------------------------------------------
>
>                 Key: OPENJPA-847
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Minor
>         Attachments: OPENJPA-847.patch
>
>
> Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENJPA-847) Retrieving database generated keys gets never enabled

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milosz Tylenda updated OPENJPA-847:
-----------------------------------

    Attachment: OPENJPA-847.patch

The patch delegates all JDBC 3 methods to the delegate instead of throwing exceptions.


> Retrieving database generated keys gets never enabled
> -----------------------------------------------------
>
>                 Key: OPENJPA-847
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: Milosz Tylenda
>            Priority: Minor
>         Attachments: OPENJPA-847.patch
>
>
> Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OPENJPA-847) Retrieving database generated keys gets never enabled

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milosz Tylenda resolved OPENJPA-847.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.3.0

Change applied also to 1.3.x branch.

> Retrieving database generated keys gets never enabled
> -----------------------------------------------------
>
>                 Key: OPENJPA-847
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Minor
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-847.patch
>
>
> Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-847) Retrieving database generated keys gets never enabled

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660061#action_12660061 ] 

Milosz Tylenda commented on OPENJPA-847:
----------------------------------------

DBDictionary says:

                metaData = conn.getMetaData();
                try {
                    // JDBC3-only method, so it might throw a 
                    // AbstractMethodError
                    isJDBC3 = metaData.getJDBCMajorVersion() >= 3;
                    supportsGetGeneratedKeys = metaData.supportsGetGeneratedKeys();
                } catch (Throwable t) {
                    // ignore if not JDBC3
                }

However, DelegatingDatabaseMetaData.supportsGetGeneratedKeys always throws an exception:

    public boolean supportsGetGeneratedKeys() throws SQLException {
        throw new UnsupportedOperationException();
    }

Now , as OpenJPA requires Java 5 (JDBC 3), we probably can delegate all DelegatingDatabaseMetaData methods to the delegate or even get rid of DelegatingDatabaseMetaData completely.


> Retrieving database generated keys gets never enabled
> -----------------------------------------------------
>
>                 Key: OPENJPA-847
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: Milosz Tylenda
>            Priority: Minor
>
> Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENJPA-847) Retrieving database generated keys gets never enabled

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milosz Tylenda reassigned OPENJPA-847:
--------------------------------------

    Assignee: Milosz Tylenda

> Retrieving database generated keys gets never enabled
> -----------------------------------------------------
>
>                 Key: OPENJPA-847
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-847
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Minor
>         Attachments: OPENJPA-847.patch
>
>
> Support for getting generated keys (OPENJPA-736) needs a bit of more work - DBDictionary.supportsGetGeneratedKeys is always false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.