You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/11/28 21:24:39 UTC

Review Request 64134: Remove Deprecated Non-Versioned LZO Packages from LZO Install

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64134/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-22536
    https://issues.apache.org/jira/browse/AMBARI-22536


Repository: ambari


Description
-------

Ambari was previously installed 4 LZO packages:

- lzo / liblzo2-2
- hadoop-lzo
- hadoop-lzo-native
- hadooplzo_${stack_version}
- hadooplzo_${stack_version}-native

The non-versioned packages contain the same files and should not be used anymore:

```
/usr/hdp/current/share/lzo/0.6.0/lib/hadoop-lzo-0.6.0.jar

[root@c6401 usr]# repoquery -l hadooplzo_2_6_3_0_230.x86_64
/usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230-javadoc.jar
/usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230-sources.jar
/usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230.jar
```

```
[root@c6401 share]# repoquery -l hadoop-lzo-native
/usr/hdp/current/share/lzo/0.6.0/lib/native
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.a
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.la
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so.0
/usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so.0.0.0
/usr/hdp/current/share/lzo/0.6.0/lib/native/docs

[root@c6401 share]# repoquery -l hadooplzo_2_6_3_0_230-native.x86_64
/usr/hdp/2.6.3.0-230/hadoop/lib/native
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.a
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.la
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so.0
/usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so.0.0.0
```


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py d6d987fda9 


Diff: https://reviews.apache.org/r/64134/diff/1/


Testing
-------

----------------------------------------------------------------------
Total run:1196
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57.608 s
[INFO] Finished at: 2017-11-28T16:23:16-05:00
[INFO] Final Memory: 18M/491M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Re: Review Request 64134: Remove Deprecated Non-Versioned LZO Packages from LZO Install

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64134/#review192066
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Nov. 28, 2017, 9:24 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64134/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 9:24 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-22536
>     https://issues.apache.org/jira/browse/AMBARI-22536
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari was previously installed 4 LZO packages:
> 
> - lzo / liblzo2-2
> - hadoop-lzo
> - hadoop-lzo-native
> - hadooplzo_${stack_version}
> - hadooplzo_${stack_version}-native
> 
> The non-versioned packages contain the same files and should not be used anymore:
> 
> ```
> /usr/hdp/current/share/lzo/0.6.0/lib/hadoop-lzo-0.6.0.jar
> 
> [root@c6401 usr]# repoquery -l hadooplzo_2_6_3_0_230.x86_64
> /usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230-javadoc.jar
> /usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230-sources.jar
> /usr/hdp/2.6.3.0-230/hadoop/lib/hadoop-lzo-0.6.0.2.6.3.0-230.jar
> ```
> 
> ```
> [root@c6401 share]# repoquery -l hadoop-lzo-native
> /usr/hdp/current/share/lzo/0.6.0/lib/native
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.a
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.la
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so.0
> /usr/hdp/current/share/lzo/0.6.0/lib/native/Linux-amd64-64/libgplcompression.so.0.0.0
> /usr/hdp/current/share/lzo/0.6.0/lib/native/docs
> 
> [root@c6401 share]# repoquery -l hadooplzo_2_6_3_0_230-native.x86_64
> /usr/hdp/2.6.3.0-230/hadoop/lib/native
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.a
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.la
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so.0
> /usr/hdp/2.6.3.0-230/hadoop/lib/native/Linux-amd64-64/libgplcompression.so.0.0.0
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py d6d987fda9 
> 
> 
> Diff: https://reviews.apache.org/r/64134/diff/1/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 57.608 s
> [INFO] Finished at: 2017-11-28T16:23:16-05:00
> [INFO] Final Memory: 18M/491M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>