[GitHub] [commons-lang] aherbert commented on pull request #1062: Syntax for optional tokens in DurationFormatUtils

["aherbert (via GitHub)" <gi...@apache.org>]

aherbert commented on PR #1062:
URL: https://github.com/apache/commons-lang/pull/1062#issuecomment-1611607319

   I think this is useful.
   
   It requires an update to the Javadoc to describe that you can use optional tokens, with some examples. Otherwise it is a hidden feature.
   
   IIUC it will effect any public method that calls the internal `lexx` and `format` methods. So this is `formatDuration` and also `formatPeriod`. So there should be tests and javadoc updates for `formatPeriod` as well.
   
   I cannot find any public methods with a user specified string format within the library that invoke these methods (since these will also need their javadoc updating). However I may have missed them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org