You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/21 00:44:28 UTC

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19368: Add unit test for EncryptForUseDefaultInsertColumnsTokenGenerator

TeslaCN commented on code in PR #19368:
URL: https://github.com/apache/shardingsphere/pull/19368#discussion_r926158029


##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/EncryptForUseDefaultInsertColumnsTokenGenerator.java:
##########
@@ -62,6 +62,9 @@ public UseDefaultInsertColumnsToken generateSQLToken(final InsertStatementContex
     }
     
     private Optional<UseDefaultInsertColumnsToken> findInsertColumnsToken() {
+        if (null == previousSQLTokens) {

Review Comment:
   `previousSQLTokens` is a Collection which should not be null in ShardingSphere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org