[jira] [Commented] (FLINK-2893) Rename recovery configuration keys

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968962#comment-14968962 ] 

ASF GitHub Bot commented on FLINK-2893:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1286

    [FLINK-2893] Rename recovery configuration keys

    For `ha.zookeeper` there were some static usages (not via `ConfigConstants`). After the first commit:
    
    ```bash
    $ flink git:(0.10) grep "ha\.zookeeper" -r . | wc -l
    0
    ```
    
    The file state backend configuration was always referenced via `ConfigConstants`.
    
    @tillrohrmann Can you have a look at this to make sure that I didn't forget anything?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink recovery-config

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1286
    
----
commit 607459bdbf18b505e285f43eaab35f8fe709c8dc
Author: Ufuk Celebi <uc...@apache.org>
Date:   2015-10-22T10:58:26Z

    [FLINK-2893] [runtime] Rename config key prefix from 'ha.zookeeper' to 'recovery.zookeeper'

commit ed6c72706abb3312c0f7cb525a3b43b73c21ca7b
Author: Ufuk Celebi <uc...@apache.org>
Date:   2015-10-22T11:00:33Z

    [FLINK-2893] [runtime] Rename config key from 'state.backend.fs.dir.recovery' => 'state.backend.fs.recoverydir'

----


> Rename recovery configuration keys
> ----------------------------------
>
>                 Key: FLINK-2893
>                 URL: https://issues.apache.org/jira/browse/FLINK-2893
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 0.10
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>             Fix For: 0.10
>
>
> Configuration keys for recovery have different prefixes:
> {code}
> recovery.mode
> ha.zookeeper.quorum
> ha.zookeeper.etc
> {code}
> Since {{recovery.mode}} accepts {{zookeeper}} as a value, we should make the configuration consistent by renaming the {{ha}} prefix to {{recovery}}.
> Furthermore the {{state.backend.fs.dir.recovery}} is inconsistent wrt {{ state.backend.fs.recoverydir}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)