You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/10/16 18:17:36 UTC
[kudu-CR] fs: update error message for mismatched UUIDs
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8283
Change subject: fs: update error message for mismatched UUIDs
......................................................................
fs: update error message for mismatched UUIDs
This patch updates the error message users get when they try to start up
a multiple Kudu processes to point to the same directory (i.e.
mismatched instance UUIDs at startup), to explain why the error is
happening.
Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
---
M src/kudu/fs/fs_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/8283/1
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] fs: update error message for mismatched UUIDs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8283
to look at the new patch set (#2).
Change subject: fs: update error message for mismatched UUIDs
......................................................................
fs: update error message for mismatched UUIDs
This patch updates the error message users get when they try to start up
multiple Kudu processes to point to the same directory (i.e. mismatched
instance UUIDs) to explain why the error is happening.
Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
---
M src/kudu/fs/fs_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/8283/2
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] fs: update error message for mismatched UUIDs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8283 )
Change subject: fs: update error message for mismatched UUIDs
......................................................................
Patch Set 2:
> (4 comments)
Ignore these comments. Forgot to discard them when you posted PS2.
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 19:14:15 +0000
Gerrit-HasComments: No
[kudu-CR] fs: update error message for mismatched UUIDs
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8283 )
Change subject: fs: update error message for mismatched UUIDs
......................................................................
Patch Set 2: Code-Review+2
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8283/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8283/1//COMMIT_MSG@10
PS1, Line 10: m
nit: extra a
http://gerrit.cloudera.org:8080/#/c/8283/1//COMMIT_MSG@10
PS1, Line 10: point t
nit: pointing to
http://gerrit.cloudera.org:8080/#/c/8283/1//COMMIT_MSG@11
PS1, Line 11: r
nit: extra ,?
http://gerrit.cloudera.org:8080/#/c/8283/1/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8283/1/src/kudu/fs/fs_manager.cc@308
PS1, Line 308: ;
nit: I think a grammarian would say this should be a :
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 19:07:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update error message for mismatched UUIDs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8283 )
Change subject: fs: update error message for mismatched UUIDs
......................................................................
fs: update error message for mismatched UUIDs
This patch updates the error message users get when they try to start up
multiple Kudu processes to point to the same directory (i.e. mismatched
instance UUIDs) to explain why the error is happening.
Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Reviewed-on: http://gerrit.cloudera.org:8080/8283
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/fs_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] fs: update error message for mismatched UUIDs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8283 )
Change subject: fs: update error message for mismatched UUIDs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0f13fc34dd2b2cba142836a575d112bcb5055e8
Gerrit-Change-Number: 8283
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 19:59:18 +0000
Gerrit-HasComments: No