You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Divesh Dutta (JIRA)" <ji...@apache.org> on 2009/03/07 17:44:56 UTC
[jira] Created: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-2233
URL: https://issues.apache.org/jira/browse/OFBIZ-2233
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Priority: Minor
Fix For: SVN trunk
If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
Implementation notes:
1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-2233:
--------------------------------
Attachment: ofbiz-2233.patch
Hello David,
Here is the updated patch after your suggestions. Now User can specify a productId, from location, and to location in order to do a quick stock move.
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-2233:
--------------------------------
Attachment: ofbiz-2233.patch
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2233:
----------------------------------
Assignee: Vikas Mayur
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698098#action_12698098 ]
Vikas Mayur commented on OFBIZ-2233:
------------------------------------
Hi Divesh,
I have tested the patch this time and its working fine. Before committing this patch I would like to know
1) The reason to create this form as a multi list form. IMO this would be just a single form.
and suggest
2) We should pass facilityId in the "To Location" lookup so that facility drop down in the look up shows the default selected facility, that is selected by the user at the very first step in the facility component.
Thanks,
Vikas
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-2233:
--------------------------------
Attachment: ofbiz-2233.patch
Hello Vikas,
Thanks again for your keen review and suggestions. This changes were really needed.
# I agree that multi-list form in not needed and this form is single-form now. New request is created for solving this purpose.
# facilityId is also passed in the 'To Location'
Thanks
Divesh
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697562#action_12697562 ]
Vikas Mayur commented on OFBIZ-2233:
------------------------------------
HI Divesh,
I did not test the patch but I would suggest you few changes
1) Form name lookupProductInventoryLocation should start with upper case letter. I would also suggest to have a different name of this form since its a list form and not a lookup form.
2) Their is no need to prefix PageTitle with the label PageTitleLookupFacilityLocation. It could be simply ProductLookupFacilityLocation.
3) Instead of this
{code}
+ <check-permission permission="FACILITY" action="_VIEW">
+ <fail-message message="Security Error: to run findProductInventorylocations you must have the FACILITY_VIEW or FACILITY_ADMIN permission"/>
+ </check-permission>
+ <check-errors/>
{code}
permission check can be added to the service definition. It would be some thing like
{code}
<permission-service service-name="facilityGenericPermission" main-action="VIEW"/>
{code}
4) I am not sure how good is to have a permission check in the service as well (as in #3) since their is already a permission check in the screen but I think its okay as the service may be used elsewhere.
{code}
+ <condition>
+ <if-service-permission service-name="facilityGenericPermission" main-action="VIEW"/>
+ </condition>
{code}
5) Since this is a list form and not a look up form. I think the following
{code}
+ <decorator-section name="search-options">
+ <include-form name="lookupProductInventoryLocation" location="component://product/webapp/facility/lookup/FieldLookupForms.xml"/>
+ </decorator-section>
+ </decorator-screen>
{code}
would be
{code}
+ <decorator-section name="search-results">
+ <include-form name="lookupProductInventoryLocation" location="component://product/webapp/facility/lookup/FieldLookupForms.xml"/>
+ </decorator-section>
+ </decorator-screen>
{code}
Thanks,
Vikas
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur closed OFBIZ-2233.
------------------------------
Resolution: Fixed
Thanks Divesh,
Your patch is in trunk rev. 764685
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680331#action_12680331 ]
David E. Jones commented on OFBIZ-2233:
---------------------------------------
This patch does not do what is described, namely allow the user to "specify a productId, from location, and to location in order to do a quick stock move".
There is no need to list all bulk locations, and in fact this isn't even meant to be exclusive to bulk locations (many of these would be from pick locations to other pick locations). On a side note, even if this was for bulk locations and we wanted to help the user doing it in this way is problematic as many users of OFBiz have tens of thousands of bulk locations in their warehouses, which would make the page run rather painfully... painful. ;)
Anyway, this should simplify your code and the form quite a bit.
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-2233:
--------------------------------
Attachment: ofbiz-2233.patch
Thanks Vikas for reviewing my patch and giving your valuable suggestions . I have uploaded the patch with all the changes.
Divesh
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch, ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-2233:
--------------------------------
Attachment: ofbiz-2233.patch
Steps for testing:
1) Go to Facility -> Stock Moves screen
2) Fill up the To Location and Quantity needed to move in Quick Stock move form
3) select the check box
4) Click on "Confirm selected move"
5) Products should be moved to specified location
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed
inventory in another location then he can do a quick Stock Move for that
inventory from the higher shelf to the main pick location
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680377#action_12680377 ]
Divesh Dutta commented on OFBIZ-2233:
-------------------------------------
Thank you so much David for reviewing this patch. I will made the changes so that user can "specify a productId, from location, and to location in order to do a quick stock move".
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2233
> URL: https://issues.apache.org/jira/browse/OFBIZ-2233
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves is based on minimum quantities on each Pick/Primary.
> And user can also move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have functionality in which User can move items from bulk inventory location to pick/primary inventory location in single click.
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.