You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/16 02:27:37 UTC

[GitHub] [dubbo] kevinw66 commented on a change in pull request #8186: [3.0] Improve async export / refer

kevinw66 commented on a change in pull request #8186:
URL: https://github.com/apache/dubbo/pull/8186#discussion_r670921248



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1103,26 +1108,25 @@ public DubboBootstrap start() {
             }
 
             referServices();
-            if (asyncExportingFutures.size() > 0 || asyncReferringFutures.size() > 0) {
-                new Thread(() -> {
+
+            // wait async export / refer finish if needed
+            awaitFinish();
+
+            new Thread(() -> {

Review comment:
       Changed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org