You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/02/22 17:30:40 UTC
[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #499: OAK-9700: RevisionGC may fail with NPE
mreutegg commented on a change in pull request #499:
URL: https://github.com/apache/jackrabbit-oak/pull/499#discussion_r812190914
##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
##########
@@ -805,7 +805,10 @@ private long getNumPreviousDocuments() {
private void addPreviousDocuments(Iterator<String> ids) throws IOException {
while (ids.hasNext()) {
- prevDocIdsToDelete.add(ids.next());
+ String id = ids.next();
+ if (id != null) {
+ prevDocIdsToDelete.add(id);
+ }
Review comment:
I like this suggestion and will update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org