You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/22 12:02:20 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #24306: Add default sharding strategy for `ConvertYamlConfigurationExecutor`
Qianyi951015 opened a new pull request, #24306:
URL: https://github.com/apache/shardingsphere/pull/24306
For #23823.
Changes proposed in this pull request:
- Add default sharding strategy for `ConvertYamlConfigurationExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24306: Add default sharding strategy for `ConvertYamlConfigurationExecutor`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24306:
URL: https://github.com/apache/shardingsphere/pull/24306#issuecomment-1439947468
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24306](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f89580) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2a6bb4fdba02e6a5d0ebf23bb89c1e2d0ba03422?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a6bb4f) will **decrease** coverage by `0.02%`.
> The diff coverage is `30.76%`.
> :exclamation: Current head 7f89580 differs from pull request most recent head 042e614. Consider uploading reports for the commit 042e614 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24306 +/- ##
============================================
- Coverage 49.97% 49.95% -0.02%
- Complexity 1573 1579 +6
============================================
Files 3253 3253
Lines 53441 53476 +35
Branches 9854 9864 +10
============================================
+ Hits 26706 26714 +8
- Misses 24366 24391 +25
- Partials 2369 2371 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eadwritesplitting/rule/ReadwriteSplittingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGVzcGxpdHRpbmcvcnVsZS9SZWFkd3JpdGVTcGxpdHRpbmdSdWxlLmphdmE=) | `56.70% <0.00%> (ø)` | |
| [...eator/ShardingSpherePipelineDataSourceCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvZGF0YS9waXBlbGluZS9kYXRhc291cmNlL2NyZWF0b3IvU2hhcmRpbmdTcGhlcmVQaXBlbGluZURhdGFTb3VyY2VDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ta/pipeline/spi/sqlbuilder/PipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NwaS9zcWxidWlsZGVyL1BpcGVsaW5lU1FMQnVpbGRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...e/exception/metadata/NoAnyRuleExistsException.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2V4Y2VwdGlvbi9tZXRhZGF0YS9Ob0FueVJ1bGVFeGlzdHNFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/pipeline/core/prepare/InventoryTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3ByZXBhcmUvSW52ZW50b3J5VGFza1NwbGl0dGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...peline/core/sharding/ShardingColumnsExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3NoYXJkaW5nL1NoYXJkaW5nQ29sdW1uc0V4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ngauss/sqlbuilder/OpenGaussPipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvb3BlbmdhdXNzL3NxbGJ1aWxkZXIvT3BlbkdhdXNzUGlwZWxpbmVTUUxCdWlsZGVyLmphdmE=) | `88.88% <0.00%> (-5.23%)` | :arrow_down: |
| [...resql/sqlbuilder/PostgreSQLPipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3Bvc3RncmVzcWwvc3FsYnVpbGRlci9Qb3N0Z3JlU1FMUGlwZWxpbmVTUUxCdWlsZGVyLmphdmE=) | `95.45% <0.00%> (-4.55%)` | :arrow_down: |
| [...e/scenario/migration/api/impl/MigrationJobAPI.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vbWlncmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL21pZ3JhdGlvbi9hcGkvaW1wbC9NaWdyYXRpb25Kb2JBUEkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ql/ral/common/constant/DistSQLScriptConstants.java](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvY29tbW9uL2NvbnN0YW50L0Rpc3RTUUxTY3JpcHRDb25zdGFudHMuamF2YQ==) | `100.00% <ø> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/shardingsphere/pull/24306?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24306: Add default sharding strategy for `ConvertYamlConfigurationExecutor`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24306:
URL: https://github.com/apache/shardingsphere/pull/24306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org