(commons-beanutils) branch master updated: Add Checkstyle ModifierOrder

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new 281f7012 Add Checkstyle ModifierOrder
281f7012 is described below

commit 281f70129c027547042fba779030b3dac2467f25
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Sun Feb 9 14:16:15 2025 -0500

    Add Checkstyle ModifierOrder
---
 src/conf/checkstyle.xml                                                 | 1 +
 .../java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java  | 2 +-
 src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java      | 2 +-
 src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java      | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 218157ef..0fba6cb6 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -42,6 +42,7 @@ limitations under the License.
     <module name="AvoidStarImport"/>
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>
+    <module name="ModifierOrder" />
     <module name="NeedBraces"/>
     <module name="ParenPad" />
     <module name="JavadocType">
diff --git a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
index de371fe3..173d7582 100644
--- a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
@@ -292,5 +292,5 @@ public abstract class BaseLocaleConverter<T> implements LocaleConverter<T> {
      * @return The converted value
      * @throws ParseException if conversion cannot be performed successfully
      */
-    abstract protected T parse(Object value, String pattern) throws ParseException;
+    protected abstract T parse(Object value, String pattern) throws ParseException;
 }
diff --git a/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java b/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java
index 6f994b52..5ce704dc 100644
--- a/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java
+++ b/src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTest.java
@@ -53,7 +53,7 @@ public class BasicDynaBeanTest {
      * The set of property names we expect to have returned when calling {@code getDynaProperties()}. You should update this list when new properties are added
      * to TestBean.
      */
-    protected final static String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "floatProperty", "intArray", "intIndexed",
+    protected static final String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "floatProperty", "intArray", "intIndexed",
             "intProperty", "listIndexed", "longProperty", "mappedProperty", "mappedIntProperty", "nullProperty", "shortProperty", "stringArray",
             "stringIndexed", "stringProperty", };
 
diff --git a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java
index 05471f52..26266d9a 100644
--- a/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java
+++ b/src/test/java/org/apache/commons/beanutils2/PropertyUtilsTest.java
@@ -94,7 +94,7 @@ public class PropertyUtilsTest {
      * The set of property names we expect to have returned when calling {@code getPropertyDescriptors()}. You should update this list when new properties are
      * added to TestBean.
      */
-    protected final static String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "dupProperty", "floatProperty", "intArray",
+    protected static final String[] properties = { "booleanProperty", "booleanSecond", "doubleProperty", "dupProperty", "floatProperty", "intArray",
             "intIndexed", "intProperty", "listIndexed", "longProperty", "nested", "nullProperty", "readOnlyProperty", "shortProperty", "stringArray",
             "stringIndexed", "stringProperty", "writeOnlyProperty", };