You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2014/05/19 02:50:20 UTC
Re: svn commit: r1595692 - /logging/log4j/log4j2/trunk/log4j-api/pom.xml
Matt,
Sorry, I should have documented this in the pom, but log4j-api can run junit tests with <reuseForks>true</reuseForks>, which reduces the build time from 22 to 10 seconds.
It looks redundant but is slightly different from the default (reuseforks=false). Again, I should've put a comment in the pom...
Can you revert this change?
I'd like log4j-core to be able to run junit tests with this setting but that may not be easy...
Remko
Sent from my iPhone
> On 2014/05/19, at 6:20, mattsicker@apache.org wrote:
>
> Author: mattsicker
> Date: Sun May 18 21:20:58 2014
> New Revision: 1595692
>
> URL: http://svn.apache.org/r1595692
> Log:
> Remove redundant surefire configuration.
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-api/pom.xml
>
> Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original)
> +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58 2014
> @@ -66,11 +66,6 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> - <configuration>
> - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine>
> - <forkCount>1</forkCount>
> - <reuseForks>true</reuseForks>
> - </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1595692 - /logging/log4j/log4j2/trunk/log4j-api/pom.xml
Posted by Matt Sicker <bo...@gmail.com>.
I'm currently testing the project with forkCount of 2C and reuseForks set
to true for everything but log4j-core. I think I can group together the
violating tests in log4j-core so we can run those separately.
On 18 May 2014 20:39, Remko Popma <re...@gmail.com> wrote:
> I've only experimented a little with forkcount for the whole project and
> that didn't go well... :-)
>
> But perhaps the tests in log4j-api can run in parallel.
> -> Just had a quick look; I don't think log4j-ap tests share any resources
> so that should be fine.
>
> Sent from my iPhone
>
> On 2014/05/19, at 10:05, Matt Sicker <bo...@gmail.com> wrote:
>
> Oh I thought I read it said false. Should I keep the forkCount, too?
>
>
> On 18 May 2014 19:50, Remko Popma <re...@gmail.com> wrote:
>
>> Matt,
>> Sorry, I should have documented this in the pom, but log4j-api can run
>> junit tests with <reuseForks>true</reuseForks>, which reduces the build
>> time from 22 to 10 seconds.
>> It looks redundant but is slightly different from the default
>> (reuseforks=false). Again, I should've put a comment in the pom...
>>
>> Can you revert this change?
>>
>> I'd like log4j-core to be able to run junit tests with this setting but
>> that may not be easy...
>>
>> Remko
>>
>> Sent from my iPhone
>>
>> > On 2014/05/19, at 6:20, mattsicker@apache.org wrote:
>> >
>> > Author: mattsicker
>> > Date: Sun May 18 21:20:58 2014
>> > New Revision: 1595692
>> >
>> > URL: http://svn.apache.org/r1595692
>> > Log:
>> > Remove redundant surefire configuration.
>> >
>> > Modified:
>> > logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> >
>> > Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original)
>> > +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58
>> 2014
>> > @@ -66,11 +66,6 @@
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> > <artifactId>maven-surefire-plugin</artifactId>
>> > - <configuration>
>> > - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine>
>> > - <forkCount>1</forkCount>
>> > - <reuseForks>true</reuseForks>
>> > - </configuration>
>> > </plugin>
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
--
Matt Sicker <bo...@gmail.com>
Re: svn commit: r1595692 - /logging/log4j/log4j2/trunk/log4j-api/pom.xml
Posted by Remko Popma <re...@gmail.com>.
I've only experimented a little with forkcount for the whole project and that didn't go well... :-)
But perhaps the tests in log4j-api can run in parallel.
-> Just had a quick look; I don't think log4j-ap tests share any resources so that should be fine.
Sent from my iPhone
> On 2014/05/19, at 10:05, Matt Sicker <bo...@gmail.com> wrote:
>
> Oh I thought I read it said false. Should I keep the forkCount, too?
>
>
>> On 18 May 2014 19:50, Remko Popma <re...@gmail.com> wrote:
>> Matt,
>> Sorry, I should have documented this in the pom, but log4j-api can run junit tests with <reuseForks>true</reuseForks>, which reduces the build time from 22 to 10 seconds.
>> It looks redundant but is slightly different from the default (reuseforks=false). Again, I should've put a comment in the pom...
>>
>> Can you revert this change?
>>
>> I'd like log4j-core to be able to run junit tests with this setting but that may not be easy...
>>
>> Remko
>>
>> Sent from my iPhone
>>
>> > On 2014/05/19, at 6:20, mattsicker@apache.org wrote:
>> >
>> > Author: mattsicker
>> > Date: Sun May 18 21:20:58 2014
>> > New Revision: 1595692
>> >
>> > URL: http://svn.apache.org/r1595692
>> > Log:
>> > Remove redundant surefire configuration.
>> >
>> > Modified:
>> > logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> >
>> > Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff
>> > ==============================================================================
>> > --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original)
>> > +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58 2014
>> > @@ -66,11 +66,6 @@
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> > <artifactId>maven-surefire-plugin</artifactId>
>> > - <configuration>
>> > - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine>
>> > - <forkCount>1</forkCount>
>> > - <reuseForks>true</reuseForks>
>> > - </configuration>
>> > </plugin>
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: svn commit: r1595692 - /logging/log4j/log4j2/trunk/log4j-api/pom.xml
Posted by Matt Sicker <bo...@gmail.com>.
That's a nifty change. It's supposed to be the default option, too. I made
the forkCount 2C.
On 18 May 2014 20:05, Matt Sicker <bo...@gmail.com> wrote:
> Oh I thought I read it said false. Should I keep the forkCount, too?
>
>
> On 18 May 2014 19:50, Remko Popma <re...@gmail.com> wrote:
>
>> Matt,
>> Sorry, I should have documented this in the pom, but log4j-api can run
>> junit tests with <reuseForks>true</reuseForks>, which reduces the build
>> time from 22 to 10 seconds.
>> It looks redundant but is slightly different from the default
>> (reuseforks=false). Again, I should've put a comment in the pom...
>>
>> Can you revert this change?
>>
>> I'd like log4j-core to be able to run junit tests with this setting but
>> that may not be easy...
>>
>> Remko
>>
>> Sent from my iPhone
>>
>> > On 2014/05/19, at 6:20, mattsicker@apache.org wrote:
>> >
>> > Author: mattsicker
>> > Date: Sun May 18 21:20:58 2014
>> > New Revision: 1595692
>> >
>> > URL: http://svn.apache.org/r1595692
>> > Log:
>> > Remove redundant surefire configuration.
>> >
>> > Modified:
>> > logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> >
>> > Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original)
>> > +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58
>> 2014
>> > @@ -66,11 +66,6 @@
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> > <artifactId>maven-surefire-plugin</artifactId>
>> > - <configuration>
>> > - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine>
>> > - <forkCount>1</forkCount>
>> > - <reuseForks>true</reuseForks>
>> > - </configuration>
>> > </plugin>
>> > <plugin>
>> > <groupId>org.apache.maven.plugins</groupId>
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: svn commit: r1595692 - /logging/log4j/log4j2/trunk/log4j-api/pom.xml
Posted by Matt Sicker <bo...@gmail.com>.
Oh I thought I read it said false. Should I keep the forkCount, too?
On 18 May 2014 19:50, Remko Popma <re...@gmail.com> wrote:
> Matt,
> Sorry, I should have documented this in the pom, but log4j-api can run
> junit tests with <reuseForks>true</reuseForks>, which reduces the build
> time from 22 to 10 seconds.
> It looks redundant but is slightly different from the default
> (reuseforks=false). Again, I should've put a comment in the pom...
>
> Can you revert this change?
>
> I'd like log4j-core to be able to run junit tests with this setting but
> that may not be easy...
>
> Remko
>
> Sent from my iPhone
>
> > On 2014/05/19, at 6:20, mattsicker@apache.org wrote:
> >
> > Author: mattsicker
> > Date: Sun May 18 21:20:58 2014
> > New Revision: 1595692
> >
> > URL: http://svn.apache.org/r1595692
> > Log:
> > Remove redundant surefire configuration.
> >
> > Modified:
> > logging/log4j/log4j2/trunk/log4j-api/pom.xml
> >
> > Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original)
> > +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58 2014
> > @@ -66,11 +66,6 @@
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-surefire-plugin</artifactId>
> > - <configuration>
> > - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine>
> > - <forkCount>1</forkCount>
> > - <reuseForks>true</reuseForks>
> > - </configuration>
> > </plugin>
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
Matt Sicker <bo...@gmail.com>