[GitHub] [iceberg] jackye1995 commented on issue #2528: Should fresh `IdentifierFieldIds` (Follow-up for PR2465)

[GitBox <gi...@apache.org>]

jackye1995 commented on issue #2528:
URL: https://github.com/apache/iceberg/issues/2528#issuecomment-827756309


   I thought about that, I think the situations are a bit different between the 2 cases.
   
   For sort order and partition spec, it has an internal reference of the updated schema which is defined only locally by the caller. So new columns can be assigned any ID. When building the replacement based on the last schema, the `assignFreshIds` is called to assign the correct ID to each new column. Then the spec and order needs to be updated with those information.
   
   For identifier, it is always referencing the schema it sits in. The identifier field ID is always resolved after the actual schema is built, so the field ID is already fresh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org