Re: [jira] Commented: (CAY-1188) Add method that lists "bad names" and show warning in Cayenne modeler

[Andrus Adamchik <an...@objectstyle.org>]

On May 11, 2009, at 10:21 AM, Andrey Razumovsky (JIRA) wrote:

> Well, I tried to add validation for the keywords (actually I took  
> them from only one list) and immediately got a bunch of warnings for  
> my datamap, which worked well for a long time. So I think this  
> feature can bring more headache that profit. Such column names as  
> "comment", "date" (or even "file") are quite popular, but they do  
> exist in the keyword list.

+1 on this analysis and -1 on trying to guess DB keywords. Let people  
call their columns anything they want.

Andrus

Re: [jira] Commented: (CAY-1188) Add method that lists "bad names" and show warning in Cayenne modeler

[Mike Kienenberger <mk...@gmail.com>]

You'd have to make it adaptor-specific.   From practical experience, I
know that "comment" and "date" are not allowed (even quoted or
delimited) as column names in Oracle.

The problem is that the data maps are not tied to a specific adaptor.
The implementation of this feature would require somehow specifying
what dialect of database you wanted to be warned against.

I think it's a reasonable idea, but I haven't heard a reasonable
implementation yet.

On Mon, May 11, 2009 at 10:34 AM, Andrus Adamchik
<an...@objectstyle.org> wrote:
>
> On May 11, 2009, at 10:21 AM, Andrey Razumovsky (JIRA) wrote:
>
>> Well, I tried to add validation for the keywords (actually I took them
>> from only one list) and immediately got a bunch of warnings for my datamap,
>> which worked well for a long time. So I think this feature can bring more
>> headache that profit. Such column names as "comment", "date" (or even
>> "file") are quite popular, but they do exist in the keyword list.
>
> +1 on this analysis and -1 on trying to guess DB keywords. Let people call
> their columns anything they want.
>
> Andrus
>
>