You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/08/25 14:32:22 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #6378: #6377: workaround vscode jar/nbjrt URI mangle
sdedic opened a new pull request, #6378:
URL: https://github.com/apache/netbeans/pull/6378
The original commit 3fd09f3 that causes this bug changed the processing since although NBLS reported nbjrt or jar URIs in form `nbjrt:file:/space/java/17/!/modules/java.base/?CLASS#java.util.Collections`, the LSP client seems to mangle the scheme and ! by urlencoding it. The original code in 3fd09f3 used URLDecoder, which demangles those parts, but also decodes other potentially URLeconded characters, such as spaces in path.
This PR handles the specific sitiuation when there are multiple (nested) schemes like `jar:file:` or `nbjrt:file:` -- these always precede the first slash. In both cases, `!` serves as a delimiter for the inner scheme's part, followed by `/`. So only these parts are searched for and demangled.
The URI is later passed to `URI.create()` that decodes the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #6378: #6377: workaround vscode jar/nbjrt URI mangle
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #6378:
URL: https://github.com/apache/netbeans/pull/6378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists