You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/01/04 01:50:11 UTC

Review Request 64942: HIVE-18274 add AM level metrics for WM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64942/
-----------------------------------------------------------

Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java 478f9492a7 


Diff: https://reviews.apache.org/r/64942/diff/1/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 64942: HIVE-18274 add AM level metrics for WM

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64942/#review194748
-----------------------------------------------------------




llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java
Lines 187 (patched)
<https://reviews.apache.org/r/64942/#comment273719>

    nit: put this under if? complicated to read.



llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java
Lines 192 (patched)
<https://reviews.apache.org/r/64942/#comment273720>

    same for all these


- Prasanth_J


On Jan. 4, 2018, 1:50 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64942/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2018, 1:50 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java 478f9492a7 
> 
> 
> Diff: https://reviews.apache.org/r/64942/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 64942: HIVE-18274 add AM level metrics for WM

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64942/
-----------------------------------------------------------

(Updated Jan. 4, 2018, 7:11 p.m.)


Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java 14bb85a865 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java 478f9492a7 


Diff: https://reviews.apache.org/r/64942/diff/2/

Changes: https://reviews.apache.org/r/64942/diff/1-2/


Testing
-------


Thanks,

Sergey Shelukhin