[GitHub] wltjr commented on issue #569: lib.nbjavac: Fix type change for Java 11

[GitBox <gi...@apache.org>]

wltjr commented on issue #569: lib.nbjavac: Fix type change for Java 11
URL: https://github.com/apache/incubator-netbeans/pull/569#issuecomment-400729944
 
 
   Seems it is safe for other versions, the test build passed with 1.8. Though this may not work for post Java 11, as it seems its [deprecated](https://github.com/dmlloyd/openjdk/blob/jdk/jdk/src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java#L42), also mentioned in [JDK 10 docs](https://docs.oracle.com/javase/10/docs/api/com/sun/javadoc/SourcePosition.html)
   
   It was not an issue under JDK 10 or 9. This is only a JDK 11 fix. It can wait till a release that targets JDK 11. No rush, more a heads up to issues with JDK 11. If not merged that is fine. There maybe a better solution for long term, as SourcePosition is set for removal. I just had to do that for JDK 11, so figured I would submit a PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists