[jira] [Comment Edited] (ARTEMIS-895) Osgi multi protocol acceptor race condition

["Ryan Yeats (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018628#comment-16018628 ] 

Ryan Yeats edited comment on ARTEMIS-895 at 5/20/17 10:13 PM:
--------------------------------------------------------------

I am afraid I am not well enough informed about how protocols should be added but if we discuss some solutions and I can find the time I can work on a PR. In the mean time here is a patch with two itests the first ArtemisFeatureMultiProtocolTest will fail intermittently because amqp won't get added in time, the second ArtemisFeatureWithCoreTest will fail to start artemis because of protocols=CORE.

https://github.com/ryeats/activemq-artemis/commit/f6742ef415c3564459be2365957f1a79a92132f8.patch

From a karaf perspective it would be nice if multi-protocol acceptors had protocols added/removed when their respective bundles were added and removed, even after the server starts (I assume this is difficult). A simpler solution would be to require all protocols to be defined and fix protocols=CORE or add core to all acceptors even when it is not specifically called out.


was (Author: ryeats):
I am afraid I am not well enough informed about how protocols should be added but if we discuss some solutions and I can find the time I can work on a PR. In the mean time here is a patch with two itests the first ArtemisFeatureMultiProtocolTest will fail intermittently because amqp won't get added in time, the second ArtemisFeatureWithCoreTest will fail to start artemis because of protocols=CORE.

From a karaf perspective it would be nice if multi-protocol acceptors had protocols added/removed when their respective bundles were added and removed, even after the server starts (I assume this is difficult). A simpler solution would be to require all protocols to be defined and fix protocols=CORE or add core to all acceptors even when it is not specifically called out.

> Osgi multi protocol acceptor race condition
> -------------------------------------------
>
>                 Key: ARTEMIS-895
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-895
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: osgi
>    Affects Versions: 1.5.1
>            Reporter: Ryan Yeats
>             Fix For: 2.2.0
>
>
> Artemis running inside of karaf has issues if the protocol doesn't have a acceptor specificly defined. On startup it is possible that it won't get added to the multi protocol acceptor if the bundle doesn't start up in time. This would be a minor issue but currenly the CORE protocol is not accepted on ports with defined protocols and CORE can't be added as a protocol so it creates alot of confusion if CORE and another protocol are being used when trying to setup acceptors.
> to reproduce remove all the acceptors besides the multi protocol acceptor and restart karaf



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)